Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

The ksm parameter was saved incorrectly #5441

Open
cheriL opened this issue Feb 13, 2023 · 0 comments · May be fixed by #5458
Open

The ksm parameter was saved incorrectly #5441

cheriL opened this issue Feb 13, 2023 · 0 comments · May be fixed by #5458
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@cheriL
Copy link

cheriL commented Feb 13, 2023

Wrong ksm parameter was saved in save_ksm_settings when testing ksm, which can affect the restore phase.

# Save the current KSM settings so we can restore them later
save_ksm_settings(){
	echo "saving KSM settings"
	ksm_stored_run=$(cat ${KSM_ENABLE_FILE})
	ksm_stored_pages=$(cat ${KSM_ENABLE_FILE})
	ksm_stored_sleep=$(cat ${KSM_ENABLE_FILE})
}
@cheriL cheriL added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Feb 13, 2023
cheriL pushed a commit to cheriL/tests that referenced this issue Feb 13, 2023
fix ksm parameter saving
070089e 
Fixes: kata-containers#5441

Signed-off-by: UnlimitedSoup <unlimitedsoup@UnlimitedSoupdeMacBook-Pro.local>
@cheriL cheriL mentioned this issue Feb 13, 2023
Closed
cheriL added a commit to cheriL/tests that referenced this issue Feb 16, 2023
@cheriL
ksm_test: fix ksm parameter saving
badc83a 
fix the files for save_ksm_settings() calling

Fixes: kata-containers#5441

Signed-off-by: soup <lqh348659137@outlook.com>
@cheriL cheriL linked a pull request Feb 16, 2023 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ksm_test: fix ksm parameter saving cheriL/tests
fix ksm parameter saving cheriL/tests
1 participant
@cheriL