Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

metrics: Fix memory inside container test #5525

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

GabyCT
Copy link
Contributor

@GabyCT GabyCT commented Mar 13, 2023

This PR replaces ctr with CTR_EXE which is defined in the metrics lib common.bash as well as it uses sudo to have uniformity across the metrics scripts.

Fixes #5524

This PR replaces ctr with CTR_EXE which is defined in the metrics lib
common.bash as well as it uses sudo to have uniformity across the
metrics scripts.

Fixes kata-containers#5524

Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
@GabyCT GabyCT added no-backport-needed Changed do not need to be applied to an older branch / repository no-forward-port-needed Changed do not need to be applied to a newer branch / repository labels Mar 13, 2023
@katacontainersbot katacontainersbot added the size/tiny Smallest and simplest task label Mar 13, 2023
@GabyCT
Copy link
Contributor Author

GabyCT commented Mar 13, 2023

/test

Copy link
Member

@snir911 snir911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@cmaf cmaf merged commit b1c5618 into kata-containers:main Mar 16, 2023
jepio added a commit to jepio/tests that referenced this pull request Aug 25, 2023
Correct the quoting so that we run the script correctly. It currently fails
with:

bash: .../tests/integration/kubernetes/cleanup_bare_metal_env.sh false: No such file or directory

Fixes: kata-containers#5525
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-backport-needed Changed do not need to be applied to an older branch / repository no-forward-port-needed Changed do not need to be applied to a newer branch / repository size/tiny Smallest and simplest task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metrics: fix memory inside container test
4 participants