You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently publish-crates checks if unpublished changes exist by querying GitHub for the last commit date. This is fine in many cases, but will result in false-positives when Cargo.tomlcontains an include or exclude field.
Instead of querying GitHub, it could make sense to iterate through the crate directory and call git directly, e.g. with git log -1 --pretty="format:%ct" /path/to/file, to get the change time while skipping over non-included files.
As far as I know cargo metadata doesn't contain include and exclude information, so this would require parsing Cargo.toml for those keys.
The text was updated successfully, but these errors were encountered:
Currently
publish-crates
checks if unpublished changes exist by querying GitHub for the last commit date. This is fine in many cases, but will result in false-positives whenCargo.toml
contains aninclude
orexclude
field.Instead of querying GitHub, it could make sense to iterate through the crate directory and call git directly, e.g. with
git log -1 --pretty="format:%ct" /path/to/file
, to get the change time while skipping over non-included files.As far as I know
cargo metadata
doesn't containinclude
andexclude
information, so this would require parsingCargo.toml
for those keys.The text was updated successfully, but these errors were encountered: