From 5bd081aac4e1b44768748e0ab7b3e0aab127f63a Mon Sep 17 00:00:00 2001 From: Shreyas Shankar Kottukkal <38888395+shreyks@users.noreply.github.com> Date: Thu, 15 Dec 2022 12:30:52 +0530 Subject: [PATCH] Updating Examples for SAP Trans (#21874) * Updating examples * Updated payload example * Updating payloads * Updating descriptions Co-authored-by: Shreyas Kottukkal --- .../2021-12-01-preview/SAPVirtualInstance.json | 18 +++++++++--------- ...es_Create_Distributed_CreateTransport.json} | 18 +++++++++--------- ...ces_Create_Distributed_MountTransport.json} | 12 ++++++------ ...nces_Create_Distributed_SkipTransport.json} | 0 4 files changed, 24 insertions(+), 24 deletions(-) rename specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/examples/sapvirtualinstances/{SAPVirtualInstances_Create_Distributed_CreateTrans.json => SAPVirtualInstances_Create_Distributed_CreateTransport.json} (96%) rename specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/examples/sapvirtualinstances/{SAPVirtualInstances_Create_Distributed_MountTrans.json => SAPVirtualInstances_Create_Distributed_MountTransport.json} (91%) rename specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/examples/sapvirtualinstances/{SAPVirtualInstances_Create_Distributed_SkipTransMount.json => SAPVirtualInstances_Create_Distributed_SkipTransport.json} (100%) diff --git a/specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json b/specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json index ef7e20c53a47..519b6a481583 100644 --- a/specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json +++ b/specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/SAPVirtualInstance.json @@ -287,14 +287,14 @@ "Create Infrastructure only for Single Server System": { "$ref": "./examples/sapvirtualinstances/SAPVirtualInstances_Create_SingleServer.json" }, - "Create Infrastructure without SAP Trans Fileshare": { - "$ref": "./examples/sapvirtualinstances/SAPVirtualInstances_Create_Distributed_SkipTransMount.json" + "Create Infrastructure without SAP Transport Directory Fileshare": { + "$ref": "./examples/sapvirtualinstances/SAPVirtualInstances_Create_Distributed_SkipTransport.json" }, - "Create Infrastructure with a new SAP Trans Fileshare": { - "$ref": "./examples/sapvirtualinstances/SAPVirtualInstances_Create_Distributed_CreateTrans.json" + "Create Infrastructure with a new SAP Transport Directory Fileshare": { + "$ref": "./examples/sapvirtualinstances/SAPVirtualInstances_Create_Distributed_CreateTransport.json" }, - "Create Infrastructure with an existing SAP Trans Fileshare": { - "$ref": "./examples/sapvirtualinstances/SAPVirtualInstances_Create_Distributed_MountTrans.json" + "Create Infrastructure with an existing SAP Transport Directory Fileshare": { + "$ref": "./examples/sapvirtualinstances/SAPVirtualInstances_Create_Distributed_MountTransport.json" }, "Detect SAP Software Installation on a Single Server System": { "$ref": "./examples/sapvirtualinstances/SAPVirtualInstances_DetectInstallation_SingleServer.json" @@ -2531,7 +2531,7 @@ }, "SkipFileShareConfiguration": { "x-ms-discriminator-value": "Skip", - "description": "Gets or sets the skip file share configuration", + "description": "Gets or sets the file share configuration for scenarios where transport directory fileshare is not created or required.", "type": "object", "allOf": [ { @@ -2541,7 +2541,7 @@ }, "CreateAndMountFileShareConfiguration": { "x-ms-discriminator-value": "CreateAndMount", - "description": "Gets or sets the file share configuration for file share created with the VIS case.", + "description": "Gets or sets the file share configuration where the transport directory fileshare is created and mounted as a part of the create infra flow.", "type": "object", "allOf": [ { @@ -2561,7 +2561,7 @@ }, "MountFileShareConfiguration": { "x-ms-discriminator-value": "Mount", - "description": "Gets or sets the file share configuration for externally mounted cases.", + "description": "Gets or sets the file share configuration where the transport directory fileshare already exists, and user wishes to mount the fileshare as a part of the create infra flow.", "type": "object", "allOf": [ { diff --git a/specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/examples/sapvirtualinstances/SAPVirtualInstances_Create_Distributed_CreateTrans.json b/specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/examples/sapvirtualinstances/SAPVirtualInstances_Create_Distributed_CreateTransport.json similarity index 96% rename from specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/examples/sapvirtualinstances/SAPVirtualInstances_Create_Distributed_CreateTrans.json rename to specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/examples/sapvirtualinstances/SAPVirtualInstances_Create_Distributed_CreateTransport.json index 5bd391ff2261..2ed66150d664 100644 --- a/specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/examples/sapvirtualinstances/SAPVirtualInstances_Create_Distributed_CreateTrans.json +++ b/specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/examples/sapvirtualinstances/SAPVirtualInstances_Create_Distributed_CreateTransport.json @@ -18,9 +18,9 @@ "appResourceGroup": "X00-RG", "storageConfiguration": { "transportFileShareConfiguration": { - "configurationType": "Mount", - "id": "fileshareID", - "privateEndpointId": "pe-arm-id" + "configurationType": "CreateAndMount", + "resourceGroup": "rgName", + "storageAccountName": "storageName" } }, "centralServer": { @@ -131,9 +131,9 @@ "appResourceGroup": "X00-RG", "storageConfiguration": { "transportFileShareConfiguration": { - "configurationType": "Mount", - "id": "fileshareID", - "privateEndpointId": "pe-arm-id" + "configurationType": "CreateAndMount", + "resourceGroup": "rgName", + "storageAccountName": "storageName" } }, "centralServer": { @@ -244,9 +244,9 @@ "appResourceGroup": "X00-RG", "storageConfiguration": { "transportFileShareConfiguration": { - "configurationType": "Mount", - "id": "fileshareID", - "privateEndpointId": "pe-arm-id" + "configurationType": "CreateAndMount", + "resourceGroup": "rgName", + "storageAccountName": "storageName" } }, "centralServer": { diff --git a/specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/examples/sapvirtualinstances/SAPVirtualInstances_Create_Distributed_MountTrans.json b/specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/examples/sapvirtualinstances/SAPVirtualInstances_Create_Distributed_MountTransport.json similarity index 91% rename from specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/examples/sapvirtualinstances/SAPVirtualInstances_Create_Distributed_MountTrans.json rename to specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/examples/sapvirtualinstances/SAPVirtualInstances_Create_Distributed_MountTransport.json index 5bd391ff2261..15394892cd97 100644 --- a/specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/examples/sapvirtualinstances/SAPVirtualInstances_Create_Distributed_MountTrans.json +++ b/specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/examples/sapvirtualinstances/SAPVirtualInstances_Create_Distributed_MountTransport.json @@ -19,8 +19,8 @@ "storageConfiguration": { "transportFileShareConfiguration": { "configurationType": "Mount", - "id": "fileshareID", - "privateEndpointId": "pe-arm-id" + "id": "/subscriptions/49d64d54-e888-4c46-a868-1936802b762c/resourceGroups/testrg/providers/Microsoft.Storage/storageAccounts/storageaccountname/fileServices/default/shares/transfileshare", + "privateEndpointId": "/subscriptions/49d64d54-e888-4c46-a868-1936802b762c/resourceGroups/testrg/providers/Microsoft.Network/privateEndpoints/endpoint" } }, "centralServer": { @@ -132,8 +132,8 @@ "storageConfiguration": { "transportFileShareConfiguration": { "configurationType": "Mount", - "id": "fileshareID", - "privateEndpointId": "pe-arm-id" + "id": "/subscriptions/49d64d54-e888-4c46-a868-1936802b762c/resourceGroups/testrg/providers/Microsoft.Storage/storageAccounts/storageaccountname/fileServices/default/shares/transfileshare", + "privateEndpointId": "/subscriptions/49d64d54-e888-4c46-a868-1936802b762c/resourceGroups/testrg/providers/Microsoft.Network/privateEndpoints/endpoint" } }, "centralServer": { @@ -245,8 +245,8 @@ "storageConfiguration": { "transportFileShareConfiguration": { "configurationType": "Mount", - "id": "fileshareID", - "privateEndpointId": "pe-arm-id" + "id": "/subscriptions/49d64d54-e888-4c46-a868-1936802b762c/resourceGroups/testrg/providers/Microsoft.Storage/storageAccounts/storageaccountname/fileServices/default/shares/transfileshare", + "privateEndpointId": "/subscriptions/49d64d54-e888-4c46-a868-1936802b762c/resourceGroups/testrg/providers/Microsoft.Network/privateEndpoints/endpoint" } }, "centralServer": { diff --git a/specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/examples/sapvirtualinstances/SAPVirtualInstances_Create_Distributed_SkipTransMount.json b/specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/examples/sapvirtualinstances/SAPVirtualInstances_Create_Distributed_SkipTransport.json similarity index 100% rename from specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/examples/sapvirtualinstances/SAPVirtualInstances_Create_Distributed_SkipTransMount.json rename to specification/workloads/resource-manager/Microsoft.Workloads/preview/2021-12-01-preview/examples/sapvirtualinstances/SAPVirtualInstances_Create_Distributed_SkipTransport.json