Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message return from Result::Ok. #240

Closed
zong-zhe opened this issue Oct 13, 2022 · 0 comments
Closed

Error message return from Result::Ok. #240

zong-zhe opened this issue Oct 13, 2022 · 0 comments
Assignees
@zong-zhe
Labels
bug Something isn't working
Milestone
v0.4.4 Release

Comments

@zong-zhe
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Method 'kclvm-runner/runner.rs/KclvmRunner.run()' return the error message by Result::Ok.

2. What did you expect to see? (Required)

Method 'kclvm-runner/runner.rs/KclvmRunner.run()' return the error message by Result::Err.

3. What did you see instead (Required)

Method 'kclvm-runner/runner.rs/KclvmRunner.run()' return the error message by Result::Ok.

4. What is your KusionStack components version? (Required)

kclvm version is 0.4.3; checksum: e07ed7af0d9bd1e86a3131714e4bd20c
@zong-zhe zong-zhe added the bug Something isn't working label Oct 13, 2022
@zong-zhe zong-zhe added this to the v0.4.4 Release milestone Oct 13, 2022
@zong-zhe zong-zhe self-assigned this Oct 13, 2022
This was referenced Oct 13, 2022
Closed
Merged
Peefy pushed a commit that referenced this issue Oct 14, 2022
@zong-zhe
Fix(kclvm-runner): Before returning the result information, add 'Resu…
521a3dd 
…lt::Ok' or 'Result::Err'. (#242)

* Fix(kclvm-runner): Before returning the result information, add 'Result::Ok' or 'Result::Err'.

In method 'runner.rs/KclvmRunner.run()', before returning the result information,
add 'Result::Ok' or 'Result::Err' to the string msg according to the content of the information.

issue #240

* remove useless

* fmt

* Restored test cases that need to be fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zong-zhe zong-zhe

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.4.4 Release
Development

No branches or pull requests
1 participant
@zong-zhe