Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add macos build and test github actions and refine windows … #124

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jul 27, 2022

…and ubuntu github actions.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re: #122

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added enhancement New feature or request ci labels Jul 27, 2022
@Peefy Peefy added this to the v0.4.3 Release milestone Jul 27, 2022
@Peefy Peefy self-assigned this Jul 27, 2022
@coveralls
Copy link
Collaborator

coveralls commented Jul 27, 2022

Pull Request Test Coverage Report for Build 2772607861

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.356%

Totals Coverage Status
Change from base Build 2758774952: 0.0%
Covered Lines: 22248
Relevant Lines: 37482

💛 - Coveralls

He1pa
He1pa previously approved these changes Jul 29, 2022
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zong-zhe
zong-zhe previously approved these changes Jul 29, 2022
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe self-requested a review August 1, 2022 06:49
@Peefy Peefy merged commit a5af743 into kcl-lang:main Aug 1, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2022
@Peefy Peefy deleted the feat-action-on-darwin branch August 5, 2022 06:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] KCLVM needs to be fully tested on different platforms in Github actions.
4 participants