Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add override print args in the exec function. #179

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Sep 2, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

#54 Add print_ast parameter on apply_overrides function.

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added the tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc. label Sep 2, 2022
@Peefy Peefy added this to the v0.4.4 Release milestone Sep 2, 2022
@Peefy Peefy self-assigned this Sep 2, 2022
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 2977832612

  • 0 of 3 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 60.418%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/src/lib.rs 0 1 0.0%
kclvm/tools/src/query/override.rs 0 2 0.0%
Totals Coverage Status
Change from base Build 2972591664: -0.002%
Covered Lines: 23789
Relevant Lines: 39374

💛 - Coveralls

@Peefy Peefy merged commit 2b09b19 into kcl-lang:main Sep 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2022
@Peefy Peefy deleted the add-overridde-args-in-exec branch November 4, 2022 12:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tool Issues or PRs related to kcl tools inlucding format, lint, validation, document tools, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants