Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(compiler-base): add util functions to span. #186

Merged
merged 7 commits into from
Sep 7, 2022
Merged

Feat(compiler-base): add util functions to span. #186

merged 7 commits into from
Sep 7, 2022

Conversation

zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Sep 7, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #115

2. What is the scope of this PR (e.g. component or file name):

compiler_base/span/src/lib.rs.
compiler_base/span/src/span.rs.

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

add util function span_to_filename_string() to get filename from SourceMap by Span.
add util function new_byte_pos() to create rustc_span::BytePos.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

add util function `span_to_filename_string()` to get filename from `SourceMap` by `Span`.
add util function `new_byte_pos()` to create `rustc_span::BytePos`.

issue #115
@zong-zhe zong-zhe added enhancement New feature or request error-handling Issues or PRs related to kcl error handling feat labels Sep 7, 2022
@zong-zhe zong-zhe added this to the v0.4.4 Release milestone Sep 7, 2022
@zong-zhe zong-zhe self-assigned this Sep 7, 2022
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3005565496

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 59.917%

Totals Coverage Status
Change from base Build 3000577825: -0.5%
Covered Lines: 22762
Relevant Lines: 37989

💛 - Coveralls

@ldxdl
Copy link
Contributor

ldxdl commented Sep 7, 2022

LGTM

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 5164ca6 into kcl-lang:main Sep 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request error-handling Issues or PRs related to kcl error handling feat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants