-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace json_minimal with serde_json #235
refactor: replace json_minimal with serde_json #235
Conversation
Pls add more test cases for |
2c648ae
to
07e0888
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b572f0a
to
a78f17c
Compare
a78f17c
to
8e5101b
Compare
Pull Request Test Coverage Report for Build 3232299325
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
re [Bug]
json.decode
raise an strange error when input invalid json string #2012. What is the scope of this PR (e.g. component or file name):
kclvm/runtime/src/3rdparty/json_minimal
kclvm/runtime/src/json/json.rs
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
replace json_minimal with serde_json to fix [Bug]
json.decode
raise an strange error when input invalid json string #2014. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
test cases in kclvm/runtime/src/value/val_json.rs:
test_value_from_err_json()
is used to test decode invalid json6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.