feature: clear object status when not synced anymore

[lionelvillard]

Feature Description

I'm opening this issue to discuss whether the status of objects that have been previously synced but not synced anymore (ie. corresponding Placement object has been deleted) should be cleared or not.

In the case of Knative, the status includes an URL pointing to the service. This URL becomes invalid when the corresponding object is not synced anymore as objects on the physical cluster are deleted.

Proposed Solution

Patch the upstream objects to remove their status when those objects are not synced anymore.

Alternative Solutions

No response

Want to contribute?

• I would like to work on this issue.

Additional Context

/cc @davidfestal

[davidfestal]

It seems that the fix would be in the Syncer virtual workspace transformations (that manage syncer views):

https://github.com/kcp-dev/kcp/blob/096dd14da2caa8f64e2b125bfdd6e75d5630ef52/tmc/pkg/virtual/syncer/transformations/transformer.go#L230

Instead of simply removing the syncer view diff annotation, it should check whether it contains fields which were promoted, and if it is the case it should clear them from the main object content.
Useful methods are getSyncerViewFields() and then, for each promoted field, field.Delete().

[mjudeikis]

/transfer-issue contrib-tmc

[mjudeikis]

/transfer-issue contrib-tmc