New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less aggressive utf16 striping #1

Open

odinuv opened this issue Dec 22, 2017 · 1 comment

Assignees

Labels

Member

odinuv commented Dec 22, 2017

This code:
https://github.com/keboola/php-utils/blob/master/src/Keboola/Utils/jsonDecode.php#L41
https://github.com/keboola/php-utils/blob/master/src/Keboola/Utils/stripInvalidUtf16.php#L12

removes even valid utf16 chars if an invalid one is encountered. This would be a better solution:
https://mnaoumov.wordpress.com/2014/06/14/stripping-invalid-characters-from-utf-16-strings/

More info: https://keboola.slack.com/archives/C02JB1749/p1513775038000189

odinuv added the enhancement label

Member

MiroCillik commented Mar 16, 2018

I will look into.

MiroCillik self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment