Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cloudeventsource type list #683

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

SpiritZhou
Copy link
Contributor

@SpiritZhou SpiritZhou commented Sep 4, 2024

Update cloudeventsource type list

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to kedacore/keda#3524

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou SpiritZhou requested a review from a team as a code owner September 4, 2024 06:10
@tomkerkhove
Copy link
Member

@SpiritZhou Can you fix the CI please?

@zroubalik
Copy link
Member

@SpiritZhou could you please fix the build?

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SpiritZhou any update on this please?

@SpiritZhou
Copy link
Contributor Author

I think my change is simple but as the CI is broken, I cannot see any build problem now.

@JorTurFer
Copy link
Member

It was a CI problem, the fix is merged and I've rebased your PR

@JorTurFer JorTurFer merged commit 5e0a8d5 into kedacore:main Nov 7, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants