diff --git a/pkg/prommetrics/adapter/adapter_prommetrics.go b/pkg/prommetrics/adapter/adapter_prommetrics.go index b4c07a004b2..fddcc7066e5 100644 --- a/pkg/prommetrics/adapter/adapter_prommetrics.go +++ b/pkg/prommetrics/adapter/adapter_prommetrics.go @@ -108,7 +108,6 @@ func (metricsServer PrometheusMetricServer) RecordHPAScalerMetric(namespace stri func (metricsServer PrometheusMetricServer) RecordHPAScalerError(namespace string, scaledObject string, scaler string, scalerIndex int, metric string, err error) { if err != nil { scalerErrors.With(getLabels(namespace, scaledObject, scaler, scalerIndex, metric)).Inc() - // scaledObjectErrors.With(prometheus.Labels{"namespace": namespace, "scaledObject": scaledObject}).Inc() metricsServer.RecordScaledObjectError(namespace, scaledObject, err) scalerErrorsTotal.With(prometheus.Labels{}).Inc() return diff --git a/pkg/prommetrics/prommetrics.go b/pkg/prommetrics/prommetrics.go index d8a401ae50b..925f7728173 100644 --- a/pkg/prommetrics/prommetrics.go +++ b/pkg/prommetrics/prommetrics.go @@ -112,7 +112,6 @@ func RecordScalerMetric(namespace string, scaledObject string, scaler string, sc func RecordScalerError(namespace string, scaledObject string, scaler string, scalerIndex int, metric string, err error) { if err != nil { scalerErrors.With(getLabels(namespace, scaledObject, scaler, scalerIndex, metric)).Inc() - // scaledObjectErrors.With(prometheus.Labels{"namespace": namespace, "scaledObject": scaledObject}).Inc() RecordScaledObjectError(namespace, scaledObject, err) scalerErrorsTotal.With(prometheus.Labels{}).Inc() return diff --git a/pkg/scaling/scale_handler.go b/pkg/scaling/scale_handler.go index 445b5d6c7d8..cb057644346 100644 --- a/pkg/scaling/scale_handler.go +++ b/pkg/scaling/scale_handler.go @@ -52,7 +52,6 @@ type ScaleHandler interface { GetScalersCache(ctx context.Context, scalableObject interface{}) (*cache.ScalersCache, error) ClearScalersCache(ctx context.Context, scalableObject interface{}) error - // GetScalersCacheForScaledObject(ctx context.Context, scaledObjectName, scaledObjectNamespace string) (*cache.ScalersCache, error) GetExternalMetrics(ctx context.Context, scaledObjectName, scaledObjectNamespace, metricName string) (*external_metrics.ExternalMetricValueList, *metricsserviceapi.PromMetricsMsg, error) }