Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide support for mounting GCP service key file for GCP scalers #1192

Closed
tomkerkhove opened this issue Sep 24, 2020 · 7 comments
Closed

Provide support for mounting GCP service key file for GCP scalers #1192

tomkerkhove opened this issue Sep 24, 2020 · 7 comments
Labels
auth Hacktoberfest help wanted Looking for support from community scaler

Comments

@tomkerkhove
Copy link
Member

Provide support for mounting GCP service key file for GCP scalers instead of environment variables.

Original request on #1188.
@tomkerkhove tomkerkhove added help wanted Looking for support from community needs-discussion feature-request All issues for new features that have not been committed to Hacktoberfest auth scaler and removed feature-request All issues for new features that have not been committed to needs-discussion labels Sep 24, 2020
@RealHarshThakur
Copy link
Contributor

Has anybody taken this up ?

@zroubalik
Copy link
Member

I am not aware of anyone.

@RealHarshThakur
Copy link
Contributor

Would be glad to take it up ! So I see that gcp scaler is reading auth creds from config.TriggerMetadata . So if I change it to read from config.Auth , will it just work or are there any other changes that I would need to do?
https://github.com/kedacore/keda/blob/v2/pkg/scalers/gcp_pub_sub_scaler.go

@stale
Copy link

stale bot commented Oct 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Oct 13, 2021
@RealHarshThakur
Copy link
Contributor

I probably forgot to mention the issue in the PR :
#1291

@stale stale bot removed the stale All issues that are marked as stale due to inactivity label Oct 14, 2021
@tomkerkhove
Copy link
Member Author

Ha, thank you! OK for you if we close this issue then @RealHarshThakur?

@RealHarshThakur
Copy link
Contributor

Yes, please :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auth Hacktoberfest help wanted Looking for support from community scaler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zroubalik @tomkerkhove @RealHarshThakur