Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug getting queues with regex using RabbitMQ Scaler #2054

Closed
JorTurFer opened this issue Aug 24, 2021 · 10 comments · Fixed by #2055
Closed

Bug getting queues with regex using RabbitMQ Scaler #2054

JorTurFer opened this issue Aug 24, 2021 · 10 comments · Fixed by #2055
Labels
bug Something isn't working
Milestone

Comments

@JorTurFer
Copy link
Member

JorTurFer commented Aug 24, 2021

Report

I have to apologize because the RabbitMQ Scaler is not working with regex :(

Idk why I totally forgot 2 important things which should be part of the query string, the page (with pagination=false is still needed the parameter page=1 ) and the regex in url format.
I'm really sorry about it and I will fix it ASAP (I start with this now) and I will also update the integration test to ensure that it works

And sorry again :(

Expected Behavior

Use regex and it works

Actual Behavior

Now all the queues are returned

KEDA Version

2.4.0

Scaler Details

RabbitMQ

@JorTurFer JorTurFer added the bug Something isn't working label Aug 24, 2021
@JorTurFer JorTurFer changed the title Bug getting queues with regex with RabbitMQ Scaler Bug getting queues with regex using RabbitMQ Scaler Aug 24, 2021
@zroubalik
Copy link
Member

OK, no worrries.

wrt testing, the best thing would be to extend current RabbitMQ e2e test and add regex scenario there: https://github.com/kedacore/keda/tree/main/tests

@JorTurFer
Copy link
Member Author

The problem is that I did the test, but it is wrong... I will fix it also :)

@crisp2u
Copy link

crisp2u commented Oct 14, 2021

Guys, any idea when we can expect a release with this fix ? I'm trying to use RabbitMQ scaler with regexe but it's not working. I've also tried running main image but the helm chart is broken.

@JorTurFer
Copy link
Member Author

JorTurFer commented Oct 14, 2021

Hi,
next release will be in the first half of November, AFAIR. Probably you are getting errors with helm and chart because an argument has changed after the kubebuilder updates.
Before the release, you need to update this line after release the chart, or maybe you can use the chart from your local

@tomkerkhove
Copy link
Member

Guys, any idea when we can expect a release with this fix ? I'm trying to use RabbitMQ scaler with regexe but it's not working. I've also tried running main image but the helm chart is broken.

Can you elaborate on the chart issue please?

@tomkerkhove tomkerkhove added this to the v2.5.0 milestone Oct 14, 2021
@JorTurFer
Copy link
Member Author

JorTurFer commented Oct 14, 2021

Guys, any idea when we can expect a release with this fix ? I'm trying to use RabbitMQ scaler with regexe but it's not working. I've also tried running main image but the helm chart is broken.

Can you elaborate on the chart issue please?

I think that it's not an issue by itself, @zroubalik updated kubebuilder version and that changed the election leader flag, the chart is updated, but it's not possible to deploy KEDA using the chart v2.4 with the image tag main because the flag in v2.4 is different.
Am I right @zroubalik ?

@crisp2u
Copy link

crisp2u commented Oct 14, 2021

@JorTurFer yeah, that's the issue, i did not want to go into details of that. I've also tried to escape metricName and queueName and add page=1 outside but still no luck

@JorTurFer
Copy link
Member Author

Maybe, could you try using local chart (or modifying the deployment manually) until the next release? Otherwise, you should wait until it 😞

@crisp2u
Copy link

crisp2u commented Oct 14, 2021

Thanks for the suggestions. I'm running a local chart now and all seems good. I'm gonna keep this in development for a while so I can wait for the next release.

@JorTurFer
Copy link
Member Author

Nice! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants