Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve e2e tests to always cleanup resources in cluster #2584

Closed
tomkerkhove opened this issue Jan 31, 2022 · 4 comments · Fixed by #2670 or #2683
Closed

Improve e2e tests to always cleanup resources in cluster #2584

tomkerkhove opened this issue Jan 31, 2022 · 4 comments · Fixed by #2670 or #2683
Assignees
@JorTurFer
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Looking for support from community testing

Comments

@tomkerkhove
Copy link
Member

Improve e2e tests to always cleanup resources in cluster, even if it was cancelled.

As per the docs, this should be possible to use a job with condition if: always().

This avoids a bad starting point for next test runs if the previous one failed or was cancelled.
@tomkerkhove tomkerkhove added enhancement New feature or request testing help wanted Looking for support from community labels Jan 31, 2022
@JorTurFer
Copy link
Member

JorTurFer commented Jan 31, 2022 •
edited
Loading

Maybe we could use a pattern for testing namespaces (now the naming is totally free) and during the test preparation, we can run the deletion to ensure that all resources are cleaned before the start (or with additional step during the workflow, ofc).
WDYT @kedacore/keda-core-contributors ?

@JorTurFer JorTurFer added the good first issue Good for newcomers label Jan 31, 2022
@tomkerkhove
Copy link
Member Author

Testing namespaces are good for me, but I'd prefer to clean things up at the end rather than the beginning to follow the boyscout rule - Clean up before you leave

@tomkerkhove tomkerkhove moved this to Backlog in Roadmap - KEDA Core Feb 10, 2022
@JorTurFer JorTurFer self-assigned this Feb 15, 2022
@JorTurFer
Copy link
Member

I'll take care about this ASAP. In the context of this I'll rename the environment variables also adding a prefix with the cloud provider (AZURE_, AWS_, GPC_,...)

@JorTurFer
Copy link
Member

Note to my self: review also azure-queue

@JorTurFer JorTurFer mentioned this issue Feb 24, 2022
Merged
5 tasks
@JorTurFer JorTurFer moved this from To Do to In Progress in Roadmap - KEDA Core Feb 24, 2022
@JorTurFer JorTurFer mentioned this issue Feb 24, 2022
Merged
5 tasks
Repository owner moved this from In Progress to Ready To Ship in Roadmap - KEDA Core Feb 28, 2022
@JorTurFer JorTurFer mentioned this issue Feb 28, 2022
Merged
5 tasks
@JorTurFer JorTurFer reopened this Feb 28, 2022
Repository owner moved this from Ready To Ship to Proposed in Roadmap - KEDA Core Feb 28, 2022
@JorTurFer JorTurFer moved this from Proposed to In Progress in Roadmap - KEDA Core Feb 28, 2022
Repository owner moved this from In Progress to Ready To Ship in Roadmap - KEDA Core Mar 1, 2022
@tomkerkhove tomkerkhove moved this from Ready To Ship to Done in Roadmap - KEDA Core Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JorTurFer JorTurFer

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Looking for support from community testing
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
2 participants
@tomkerkhove @JorTurFer