Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving rabbitMq host to resolved value #347

Merged
merged 1 commit into from
Sep 9, 2019
Merged

moving rabbitMq host to resolved value #347

merged 1 commit into from
Sep 9, 2019

Conversation

jeffhollan
Copy link
Member

@jeffhollan jeffhollan commented Sep 7, 2019

resolve #89

Making a WIP PR as there is a big question on how we release this as it will be breaking.

@jeffhollan jeffhollan marked this pull request as ready for review September 7, 2019 03:50
@jeffhollan jeffhollan requested a review from yaron2 as a code owner September 7, 2019 03:50
@jeffhollan jeffhollan changed the title moving rabbitMq host to resolved value WIP moving rabbitMq host to resolved value Sep 7, 2019
@jeffhollan
Copy link
Member Author

Actually one thought here that may add consistency and make non-breaking too.

Potentially we can add a new property called connection that resolves from Env. For the time being we could support both (host as a literal value, connection as a resolved value). Before we 1.0 we would remove support for host and only accept connection. This would also make naming more in line with other scalers.

@tomkerkhove
Copy link
Member

@jeffhollan Given this is still in "alpha"/"beta" and we have the auth changes coming up, I would just consider it as breaking change.

We've discussed this as well for the auth changes and would suggest to introduce a versioned image tag which contains the new features for more stable images

@jeffhollan
Copy link
Member Author

Ok great - yeah let's just do as-is and change how host behaves. @ahmelsayed is going to take a snapshot version of current keda:latest so that people can easily roll back to it as needed if they break from this PR, and the many more around auth spec that will start rolling out

@jeffhollan jeffhollan changed the title WIP moving rabbitMq host to resolved value moving rabbitMq host to resolved value Sep 9, 2019
@ahmelsayed
Copy link
Contributor

Thanks @jeffhollan :)

@ahmelsayed ahmelsayed merged commit 935de11 into kedacore:master Sep 9, 2019
@ahmelsayed
Copy link
Contributor

btw, kedacore/keda:0.2 is the snapshot. I updated :latest to :master right before this merge. Will update it again to include this once the build is done on dockerhub.

@jeffhollan jeffhollan deleted the rabbitmq-fix branch September 9, 2019 21:34
preflightsiren pushed a commit to preflightsiren/keda that referenced this pull request Nov 7, 2021
Fixed the date format form `mm:hh:ss` to `hh:mm:ss`

Signed-off-by: Nir Geier <nirgeier@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move rabbitmq password to environment.
3 participants