Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefix support to Google Cloud Platform Storage scaler #3756

Closed
wrdls opened this issue Oct 18, 2022 · 2 comments · Fixed by #3774
Closed

Add prefix support to Google Cloud Platform Storage scaler #3756

wrdls opened this issue Oct 18, 2022 · 2 comments · Fixed by #3774
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@wrdls
Copy link
Contributor

wrdls commented Oct 18, 2022

Proposal

Add prefix support to Google Cloud Platform Storage scaler.

Similar to blobPrefix in Azure Blob Storage.

This value is currently hardcoded to "" in the code: https://github.com/kedacore/keda/blob/main/pkg/scalers/gcp_storage_scaler.go#L194

Use-Case

This allows us to only watch part of a bucket.

Anything else?

I might be able to contribute this myself but I thought I'd already open the issue to see if this is acceptable.
@wrdls wrdls added feature-request All issues for new features that have not been committed to needs-discussion labels Oct 18, 2022
@tomkerkhove tomkerkhove moved this to Proposed in Roadmap - KEDA Core Oct 18, 2022
@zroubalik
Copy link
Member

This is definitely useful improvement, shall I assign the issue to you @wrdls ?

@JorTurFer
Copy link
Member

Agree, this is a really useful improvement 😄

@wrdls wrdls mentioned this issue Oct 25, 2022
Merged
5 tasks
Repository owner moved this from Proposed to Ready To Ship in Roadmap - KEDA Core Nov 3, 2022
@JorTurFer JorTurFer moved this from Ready To Ship to Done in Roadmap - KEDA Core Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GCP Storage scaler: Add Prefix and Delimiter support wrdls/keda
3 participants
@zroubalik @wrdls @JorTurFer