-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to add user given CAs to trusted store #4168
Comments
I have been thinking about this, and I'm not sure which is the best approach 🤔 In the other hand, the approach of reading all the certs from a single path could be complicated to test using kustomize... Maybe as starting point, we can add the support to read all the certs in a given folder and that's all (all the trusted CAs would be mounted and read from a single directory and trust in them for any HTTP request) WDYT @kedacore/keda-core-contributors ? |
Yeah, I agree with the approach. Start with the global store but also support it on TriggerAuth ClusterTriggerAuth level. |
@JorTurFer Please keep in mind that as a User I can configure the AWS MSK cluster using TLS without ACM private certificate . So there should be option for using tls without specifying custom certificate |
Hi @QualoZe0t ,
|
@JorTurFer so once ,,default,, AWS CA certificates will be registered in the trusted store then doesn't matter if I wll use or not use ACM option will be able to establish connectivity between KEDA and MSK kafka ? |
I can't guarantee that this is the only problem, but definitively the certificate should be valid or ignorable, otherwise sarama client will raise an error. |
Proposal
There are some cases where a user could want to use TLS with custom CAs in their own services, and KEDA should support an option to add those CAs to trusted store.
As the container is distroless, I'd add it using golang directly
Is this a feature you are interested in implementing yourself?
Yes
The text was updated successfully, but these errors were encountered: