Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kinesis stream scaler #526

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

msfuko
Copy link
Contributor

@msfuko msfuko commented Dec 23, 2019

  • Reason for Kinesis scaler:
    for any running Kinesis Client Library (KCL) application, a shard only has one owner. The pod# can't be scaled larger than open shard count for a KCL application. This scaler is to export current open shard count as scaling metrics, so users can decide how many shards that one consumer handles.
  • Doc kedacore/keda-doc#61
  • This PR also includes the fix of the key mismatch (awsAccessKeyId and awsAccessKeyID) between docs, authParams and UTs.

@msftclas
Copy link

msftclas commented Dec 23, 2019

CLA assistant check
All CLA requirements met.

@msfuko msfuko force-pushed the kinesis_stream_scaler branch 2 times, most recently from b4bc39e to 17b5fa7 Compare December 23, 2019 20:25
@msfuko msfuko force-pushed the kinesis_stream_scaler branch 2 times, most recently from c6df3df to 6644c18 Compare December 23, 2019 20:50
pkg/scalers/aws_cloudwatch_test.go Outdated Show resolved Hide resolved
test.yaml Outdated Show resolved Hide resolved
@msfuko msfuko force-pushed the kinesis_stream_scaler branch 3 times, most recently from 887504e to c0d86d7 Compare December 24, 2019 12:15
@msfuko msfuko force-pushed the kinesis_stream_scaler branch from c0d86d7 to f6943a1 Compare January 7, 2020 16:41
@msfuko msfuko force-pushed the kinesis_stream_scaler branch from f6943a1 to de0cc5e Compare January 7, 2020 19:56
@ahmelsayed ahmelsayed merged commit f2aaa35 into kedacore:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants