You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current github-runner-scaler implementation is unable to use GitHub App private key to authenticate against custom API endpoint, eg. GitHub Enterprise Server (GHES).
Expected Behavior
github-runner-scaler respects custom URL in githubApiURL trigger parameter when appKey is used.
Actual Behavior
github-runner-scaler and the undelying github.com/bradleyfalzon/ghinstallation/v2 tries to use https://api.github.com even if custom URL in githubApiURL trigger parameter is set to our GHES API endpoint.
Steps to Reproduce the Problem
Use githubApiURL and point it to your own GH instance, eg. GHES.
Set applicationID, installationID, and appKey of an GitHub App for authentication.
KEDA fails to authenticate as it always contacts the default public endpoint.
Logs from KEDA operator
2024-01-16T16:49:53Z ERROR github_runner_scaler error getting workflow queue length {"type": "ScaledJob", "namespace": "<some ns>", "name": "github-runner-scaledobject", "error": "Get \"https://<our ghes DNS>/api/v3/repos/<org>/<repo>/actions/runs\": could not refresh installation id 57's token: could not get access_tokens from GitHub API for installation ID 57: read tcp 100.66.130.203:59138->140.82.121.6:443: read: connection reset by peer"}
github.com/kedacore/keda/v2/pkg/scalers.(*githubRunnerScaler).GetMetricsAndActivity
/workspace/pkg/scalers/github_runner_scaler.go:652
github.com/kedacore/keda/v2/pkg/scaling/cache.(*ScalersCache).GetMetricsAndActivityForScaler
/workspace/pkg/scaling/cache/scalers_cache.go:139
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).getScaledJobMetrics
/workspace/pkg/scaling/scale_handler.go:778
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).isScaledJobActive
/workspace/pkg/scaling/scale_handler.go:807
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).checkScalers
/workspace/pkg/scaling/scale_handler.go:260
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).startScaleLoop
/workspace/pkg/scaling/scale_handler.go:180
Note the target IP: 140.82.121.6:443 -> reverse lookup points to github.com
KEDA Version
2.12.1
Kubernetes Version
1.27
Platform
Google Cloud
Scaler Details
github-runner-scaler
Anything else?
No response
The text was updated successfully, but these errors were encountered:
Report
Current github-runner-scaler implementation is unable to use GitHub App private key to authenticate against custom API endpoint, eg. GitHub Enterprise Server (GHES).
Expected Behavior
github-runner-scaler respects custom URL in
githubApiURL
trigger parameter whenappKey
is used.Actual Behavior
github-runner-scaler and the undelying github.com/bradleyfalzon/ghinstallation/v2 tries to use https://api.github.com even if custom URL in
githubApiURL
trigger parameter is set to our GHES API endpoint.Steps to Reproduce the Problem
githubApiURL
and point it to your own GH instance, eg. GHES.applicationID
,installationID
, andappKey
of an GitHub App for authentication.Logs from KEDA operator
Note the target IP:
140.82.121.6:443
-> reverse lookup points to gh.neting.ccKEDA Version
2.12.1
Kubernetes Version
1.27
Platform
Google Cloud
Scaler Details
github-runner-scaler
Anything else?
No response
The text was updated successfully, but these errors were encountered: