Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a scaled_object label to the keda_webhook_scaled_object_validation_errors_total metric #6069

Closed
nikimanoledaki opened this issue Aug 13, 2024 · 2 comments
Labels
feature-request All issues for new features that have not been committed to needs-discussion stale All issues that are marked as stale due to inactivity

Comments

@nikimanoledaki
Copy link

nikimanoledaki commented Aug 13, 2024

Proposal

This is to request adding a label to the KEDA Admission Webhook's Prometheus metric scaled_object_validation_errors_total to specify which ScaledObject is experiencing the validation error e.g. a label such as scaled_object.

The metric already has labels to indicate the namespace and the reason, which is great. However it is not possible to know which ScaledObject is experiencing this validation error.

Use-Case

This would speed up the process of finding out which ScaledObject is experiencing a validation error.

Currently, the only way to do this is to look at the KEDA Admission Webhook's logs for a validation error. However, those logs don't show the ScaledObject's namespace, so it is not possible to rely solely on the logs either.

Is this a feature you are interested in implementing yourself?

Maybe

Anything else?

I could help to implement this with some help and instructions.

I understand that adding a new label such as scaled_object may require more investigation.

@nikimanoledaki nikimanoledaki added feature-request All issues for new features that have not been committed to needs-discussion labels Aug 13, 2024
Copy link

stale bot commented Oct 19, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Oct 19, 2024
Copy link

stale bot commented Oct 29, 2024

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Oct 29, 2024
@github-project-automation github-project-automation bot moved this from To Triage to Ready To Ship in Roadmap - KEDA Core Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion stale All issues that are marked as stale due to inactivity
Projects
Status: Ready To Ship
Development

No branches or pull requests

1 participant