Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define KEDA readiness and liveness probes #788

Closed
zroubalik opened this issue Apr 28, 2020 · 14 comments
Closed

Define KEDA readiness and liveness probes #788

zroubalik opened this issue Apr 28, 2020 · 14 comments
Assignees
Labels
docs:pending All issues where docs are pending addition/update feature All issues for new features that have been committed to
Milestone

Comments

@zroubalik
Copy link
Member

KEDA should report it state/availability to the kubernetes cluster.

@zroubalik zroubalik added the feature-request All issues for new features that have not been committed to label Apr 28, 2020
@zroubalik zroubalik added this to the v2.0 milestone Apr 28, 2020
@zroubalik zroubalik self-assigned this Apr 28, 2020
@tomkerkhove
Copy link
Member

Duplicate of #237?

@zroubalik
Copy link
Member Author

@tomkerkhove no, these are probes for the KEDA Operator deployment, to expose KEDA state to the cluster. #237 is talking about probes on the target deployment and scaling based on the probes there.

@tomkerkhove
Copy link
Member

Oh I've missed that, fully agree on this one then!

@zroubalik
Copy link
Member Author

Fixed in #792

@tomkerkhove tomkerkhove added docs:pending All issues where docs are pending addition/update feature All issues for new features that have been committed to and removed feature-request All issues for new features that have not been committed to labels Aug 17, 2020
@tomkerkhove
Copy link
Member

Can we get some docs on this on https://keda.sh/docs/2.0/operate/?

@tomkerkhove tomkerkhove reopened this Aug 17, 2020
@zroubalik
Copy link
Member Author

I am not sure this is something worth documenting. Those probes exposes state of the Operator and Metrics Server Deployment toward kubernetes, eg. kubernetes scheduler knows when the Deployment is not available and should try to spin another pod.

@tomkerkhove
Copy link
Member

Let's close since it's part of our YAML & chart?

@hila3000
Copy link

@zroubalik @tomkerkhove Where can I see the Yamls and Chart? I want to see examples of liveness/readiness configuration.

@tomkerkhove
Copy link
Member

Chart can be found here: https://github.com/kedacore/charts/tree/master/keda

@hila3000
Copy link

hila3000 commented Jan 20, 2021

@tomkerkhove I don't see there an example for scaledobject.yaml.

This is what I have from version 1.5.0. Should it tweaked to be compatible with v2.0.0?

apiVersion: keda.k8s.io/v1alpha1
kind: ScaledObject
metadata:
  name: lf-scaledobject-{{ .Values.tenantId }}
  namespace: {{ .Values.lf_namespace }}
  labels:
    deploymentName: log-forwarding-{{ .Values.tenantId }}
spec:
  scaleTargetRef:
    deploymentName: log-forwarding-{{ .Values.tenantId }}
  pollingInterval: 180
  cooldownPeriod:  43200
  minReplicaCount: 0
  maxReplicaCount: 5
  triggers:
  - type: gcp-pubsub
    metadata:
      subscriptionSize: "50"
      subscriptionName: "lf-data-{{ .Values.tenantId }}-sub"
      credentials: GENERIC_GOOGLE_CREDENTIALS

@tomkerkhove
Copy link
Member

The probes are for KEDA runtime, ScaledObject scales your workload, so you are in control of those probes.

@tomkerkhove
Copy link
Member

Or maybe I'm not fully getting your question.

@zroubalik
Copy link
Member Author

You can refer Migration Guide https://keda.sh/docs/2.0/migration/

@hila3000
Copy link

Exactly what I needed :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs:pending All issues where docs are pending addition/update feature All issues for new features that have been committed to
Projects
None yet
Development

No branches or pull requests

3 participants