From b932395dcb383b4c84ae3ec2fa8d58840296ff99 Mon Sep 17 00:00:00 2001 From: Leonid Solovey <38634160+lsolovey@users.noreply.github.com> Date: Wed, 21 Jun 2023 00:14:17 -0400 Subject: [PATCH] fix: exclude Azure Monitor scaler from metricName deprecation Signed-off-by: Leonid Solovey <38634160+lsolovey@users.noreply.github.com> --- CHANGELOG.md | 1 + apis/keda/v1alpha1/scaletriggers_types.go | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 07dcff3692a..0f460642e9e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -71,6 +71,7 @@ To learn more about active deprecations, we recommend checking [GitHub Discussio - **Admission Webhooks**: Check ScaledObjects with multiple triggers with non unique name ([#4664](https://github.com/kedacore/keda/issue/4664)) - **ScaledJob**: Check if MaxReplicaCount is nil before access to it ([#4568]https://github.com/kedacore/keda/issues/4568) - **AWS SQS Scaler**: Respect `scaleOnInFlight` value ([#4276](https://github.com/kedacore/keda/issue/4276)) +- **Azure Monitor**: Exclude Azure Monitor scaler from metricName deprecation ([#4713](https://github.com/kedacore/keda/pull/4713)) - **Azure Pipelines**: Fix for disallowing `$top` on query when using `meta.parentID` method ([#4397]) - **Azure Pipelines**: Respect all required demands ([#4404](https://github.com/kedacore/keda/issues/4404)) - **NATS Jetstream Scaler**: Fix compatibility if node is not advertised ([#4524](https://github.com/kedacore/keda/issues/4524)) diff --git a/apis/keda/v1alpha1/scaletriggers_types.go b/apis/keda/v1alpha1/scaletriggers_types.go index 7214e0b2047..0e727c39570 100644 --- a/apis/keda/v1alpha1/scaletriggers_types.go +++ b/apis/keda/v1alpha1/scaletriggers_types.go @@ -65,8 +65,8 @@ func ValidateTriggers(logger logr.Logger, triggers []ScaleTriggers) error { // FIXME: DEPRECATED to be removed in v2.12 _, hasMetricName := trigger.Metadata["metricName"] - // aws-cloudwatch and huawei-cloudeye have a meaningful use of metricName - if hasMetricName && trigger.Type != "aws-cloudwatch" && trigger.Type != "huawei-cloudeye" { + // aws-cloudwatch, huawei-cloudeye and azure-monitor have a meaningful use of metricName + if hasMetricName && trigger.Type != "aws-cloudwatch" && trigger.Type != "huawei-cloudeye" && trigger.Type != "azure-monitor" { logger.Info("\"metricName\" is deprecated and will be removed in v2.12, please do not set it anymore", "trigger.type", trigger.Type) }