Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(datasets): Add official support for python 3.13 #938

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Nov 21, 2024

Description

Related to kedro-org/kedro#4267

NOTE:

Kedro-datasets - blocked by tensorflow

Development notes

  • Update CI build to include python 3.13

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes
  • Received approvals from at least half of the TSC (required for adding a new, non-experimental dataset)

skip tensorflow for py313

Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
deepyaman and others added 3 commits November 28, 2024 05:02
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
Signed-off-by: Nok <nok.lam.chan@quantumblack.com>
@noklam
Copy link
Contributor

noklam commented Nov 29, 2024

Took me a while to notice the blocker is ibis as it is updated in main two months ago but haven't done a release. Pending for response, we can either wait for the next ibis release, or drop ibis support for Python 3.13 (same as Tensorflow) until they officially support it.

@ravi-kumar-pilla
Copy link
Contributor Author

Hi @astrojuanlu and @noklam,

There seems to be some more libraries which do not yet support python 3.13. I have updated the list here. I have commented the pytests for few and also added conditional package installations in pyproject.toml. I feel this is becoming a bit messy and would like to get your thoughts.

Can we do a kedro-datasets 6.0.0 release without python 3.13 support ? If not do you see any other way to implement this ?

Thank you

@astrojuanlu
Copy link
Member

There seems to be some more libraries which do not yet support python 3.13. I have updated the list #938 (comment). I have commented the pytests for few and also added conditional package installations in pyproject.toml. I feel this is becoming a bit messy and would like to get your thoughts.

I agree with making the 6.0.0 release without Python 3.13 support 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants