Skip to content

Commit

Permalink
Note change from pkg_requirements
Browse files Browse the repository at this point in the history
See pypa/packaging#644 (comment)

Signed-off-by: Juan Luis Cano Rodríguez <juan_luis_cano@mckinsey.com>
  • Loading branch information
astrojuanlu committed May 30, 2023
1 parent 2622da6 commit 2dd7074
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions kedro/framework/cli/micropkg.py
Original file line number Diff line number Diff line change
Expand Up @@ -876,6 +876,9 @@ def _append_package_reqs(
requirements_txt: Path, package_reqs: list[str], package_name: str
) -> None:
"""Appends micro-package requirements to project level requirements.txt"""
# NOTE: packaging.requirements.Requirement equality check
# does not normalize names, and as such is not equivalent to pkg_resources.Requirement,
# see https://github.com/pypa/packaging/issues/644#issuecomment-1567982812
incoming_reqs = _safe_parse_requirements(package_reqs)
if requirements_txt.is_file():
existing_reqs = _safe_parse_requirements(requirements_txt.read_text())
Expand Down

0 comments on commit 2dd7074

Please sign in to comment.