-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AUTO-MERGE] Merge main into develop via merge-main-to-develop #1263
Conversation
…kedro into merge-main-to-develop Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
It's weird that the coverage is failing for tests/framework/cli/micropkg/conftest.py
.. Firstly, I'm wondering if coverage should be run on test files at all (I raised this point in my PR for python 3.10 as well), but secondly, this conftest was copied right, so how come it was covered fine before? 🤔
I think it's because those lines were covered in |
Ah okay, so maybe the fixture can be cleaned up a bit? |
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick comments before final review (got 2 files left)
Signed-off-by: SajidAlamQB <90610031+SajidAlamQB@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
setup( | ||
name="{name}", | ||
version="{version}", | ||
description="Modular pipeline `{name}`", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I should've seen this before, but this shouldn't refer to modular pipelines.
A new change in main cannot be merged into develop as part of the regular sync job, hence this PR. Please resolve the conflicts manually, and make sure to obtain 2 approvals once the builds pass.
IMPORTANT NOTICE
Please let CircleCI merge this PR automatically, with merge commit enabled.