Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls support is broken #12

Closed
ghost opened this issue Mar 20, 2022 · 2 comments · Fixed by #15
Closed

tls support is broken #12

ghost opened this issue Mar 20, 2022 · 2 comments · Fixed by #15

Comments

@ghost
Copy link

ghost commented Mar 20, 2022

Trying from the LTS version of Node.js, looks like the TLS connection is broken

$ node example/bitcoin.js
Connecting....

And the process is auto killed without any error logs

I assume that the library is broken, or have incompatible behavior with modern nodejs version

( I think this is the reason why ci fails as well )

cc @nkuba

@ghost
Copy link
Author

ghost commented Mar 20, 2022

Also, this comment is wrong

https://github.com/keep-network/electrum-client-js/blob/main/test/config.js#L18

I have tried with my electrum desktop client, and the server was working well.

@ghost
Copy link
Author

ghost commented Mar 20, 2022

So, I assume that the documentation of node.js is quite wrong with new tls.TLSSocket since many people use tls.connect instead.

See also nodejs/node#3963

Reverting the PR #10 fixed the issue.

This was referenced Mar 20, 2022
Closed
Closed
@nkuba nkuba closed this as completed in #15 Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants