Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modernize type declarations #299

Merged
merged 1 commit into from
Jul 8, 2023
Merged

fix: modernize type declarations #299

merged 1 commit into from
Jul 8, 2023

Conversation

regseb
Copy link
Contributor

@regseb regseb commented Jul 8, 2023

I get this error when I check my code that imports sort-package-json.

node_modules/sort-package-json/index.d.ts:49:1 - error TS1203: Export assignment cannot be used when
targeting ECMAScript modules. Consider using 'export default' or another module format instead.

49 export = sortPackageJsonExports

In this pull request, I've replaced the old syntax export= by export default and export. I've also removed sortObjectBy and Field that weren't being used.

@keithamus keithamus merged commit 058d8cb into keithamus:main Jul 8, 2023
@github-actions
Copy link

github-actions bot commented Jul 8, 2023

🎉 This PR is included in version 2.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@regseb regseb deleted the type-declarations branch July 8, 2023 21:15
@tunnckoCore tunnckoCore mentioned this pull request Oct 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@regseb @keithamus