Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add exports field #88

Merged
merged 1 commit into from
Dec 3, 2019
Merged

feat: add exports field #88

merged 1 commit into from
Dec 3, 2019

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Dec 3, 2019 •
edited
Loading

@fisker
Copy link
Collaborator Author

fisker commented Dec 3, 2019

I didn't see #84 when I send this PR, I think better put exports above main, since this could be object.

If we put it under main, it should go under all those fields

  'main',
  'umd:main',
  'jsdelivr',
  'unpkg',
  'module',
  'source',
  'jsnext:main',
  'browser',
  'types',
  'typings',
  'style',
  'example',
  'examplestyle',
  'assets',
  'bin',
  'man',

@fisker fisker mentioned this pull request Dec 3, 2019
Closed
@keithamus keithamus merged commit 092b9d7 into keithamus:master Dec 3, 2019
@keithamus
Copy link
Owner

🎉 This PR is included in version 1.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fisker fisker deleted the exports-field branch December 3, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sorting of "exports" field
2 participants
@fisker @keithamus