Fix issue of space in a folder or filename breaking PJS on Windows - done

[kensoh]

source - telegram group chat

[kensoh]

macOS / Linux
space in flow filename - OK
space in flow folder name - OK
space in folder path to tagui - OK

Windows
space in flow filename - CasperJS has problem passing filename to PhantomJS
space in flow folder name - CasperJS has problem passing filename to PhantomJS
space in folder path to tagui - OK

[kensoh]

Digging further for Windows on the root cause of CJS not passing correctly to PJS,
https://stackoverflow.com/questions/42069477/how-casperjs-passing-arguments-with-space

[kensoh]

Above commit now allows folders and filenames with spaces on all OSes. You can download the latest copy of TagUI with this fix and unzip to overwrite your existing installation (please drag the folders under tagui\src to overwrite your existing installation) - https://github.com/kelaberetiv/TagUI/archive/master.zip

In the next release, this fix will become part of the packaged zip files.

Fyi @ruthtxh found a workaround for it. Solution doesn't make sense but seems to work. No change for now on your MS Word plug-in. Because this isn't released yet as part of packaged release.

[kensoh]

Reopening to handle space in subflows??

[kensoh]

Seems to be ok, just need to wrap in double quotes from Word plugin side when calling tagui from command line.

function expand_intent($script_line, $indentation_for_tagui_step) { // function to call other scripts for reusability
if ((strpos(strtolower(trim($script_line)),'tagui ') === 0) or (strtolower(trim($script_line)) == 'tagui')) {
$params = trim(substr(trim($script_line)." ",1+strpos(trim($script_line)." "," "))); if ($params == "")
die("ERROR - filename missing for step " . trim($script_line) . "\n");
else if (!file_exists(abs_file($params)))
die("ERROR - file not found for step " . trim($script_line) . "\n");
else {$indentation_for_tagui_step .= str_replace(ltrim($script_line),'',$script_line);
$expanded_intent = ""; $temp_input_file = fopen(abs_file($params),'r'); if ($temp_input_file == false)
die("ERROR - cannot open file for step " . trim($script_line) . "\n");
while(!feof($temp_input_file)) {$expanded_intent .= expand_intent(fgets($temp_input_file),$indentation_for_tagui_step);}
fclose($temp_input_file); return $expanded_intent;}} else return $indentation_for_tagui_step . rtrim($script_line) . "\n";}

[kensoh]

above commit prevents some error on Windows due to space in filename being treated by for command as 2 parameters

[kensoh]

Users can download the latest copy of TagUI with this fix and unzip to overwrite your existing installation (please drag the folders under tagui\src to overwrite your existing installation) - https://github.com/kelaberetiv/TagUI/archive/master.zip

In the next release, this fix will become part of the packaged zip files.

[kensoh]

Closing issue, change included in latest packaged release - https://github.com/kelaberetiv/TagUI/releases/tag/v6.46.0