test: add TS types check #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intcreator
reviewed
Aug 26, 2023
intcreator
approved these changes
Aug 26, 2023
sheerlox
force-pushed
the
test/add-typings-tests
branch
from
0845739 to
cf8076f
Compare
ncb000gt
pushed a commit
that referenced
this pull request
Aug 26, 2023
|
🎉 This PR is included in version 2.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
sheerlox
added a commit
to sheerlox/node-cron
that referenced
this pull request
Sep 10, 2023
ncb000gt
pushed a commit
that referenced
this pull request
Sep 10, 2023
## [3.0.0-beta.4](v3.0.0-beta.3...v3.0.0-beta.4) (2023-09-10) ### 🐛 Bug Fixes * **deps:** update dependency luxon to v3.3.0 & add [@types](https://github.com/types)/luxon ([#689](#689)) ([c95a449](c95a449)), closes [#688](#688) * fix range parsing when upper limit = 0 ([#687](#687)) ([d96746f](d96746f)) ### 🚨 Tests * add TS types check ([#690](#690)) ([f046016](f046016))
|
🎉 This PR is included in version 3.0.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
patrickm68
added a commit
to patrickm68/node-cron-types
that referenced
this pull request
Sep 14, 2023
## [2.4.3](kelektiv/node-cron@v2.4.2...v2.4.3) (2023-08-26) ### 🐛 Bug Fixes * fix range parsing when upper limit = 0 ([#687](kelektiv/node-cron#687)) ([d96746f](kelektiv/node-cron@d96746f)) ### 🚨 Tests * add TS types check ([#690](kelektiv/node-cron#690)) ([f046016](kelektiv/node-cron@f046016))
sheerlox
added a commit
that referenced
this pull request
Sep 27, 2023
sheerlox
pushed a commit
that referenced
this pull request
Sep 27, 2023
sheerlox
added a commit
to sheerlox/node-cron
that referenced
this pull request
Sep 27, 2023
sheerlox
pushed a commit
to sheerlox/node-cron
that referenced
this pull request
Sep 27, 2023
## [2.4.3](kelektiv/node-cron@v2.4.2...v2.4.3) (2023-08-26) ### 🐛 Bug Fixes * fix range parsing when upper limit = 0 ([kelektiv#687](kelektiv#687)) ([d96746f](kelektiv@d96746f)) ### 🚨 Tests * add TS types check ([kelektiv#690](kelektiv#690)) ([f046016](kelektiv@f046016))
sheerlox
added a commit
to sheerlox/node-cron
that referenced
this pull request
Sep 29, 2023
sheerlox
pushed a commit
to sheerlox/node-cron
that referenced
this pull request
Sep 29, 2023
## [2.4.3](kelektiv/node-cron@v2.4.2...v2.4.3) (2023-08-26) ### 🐛 Bug Fixes * fix range parsing when upper limit = 0 ([kelektiv#687](kelektiv#687)) ([d96746f](kelektiv@d96746f)) ### 🚨 Tests * add TS types check ([kelektiv#690](kelektiv#690)) ([f046016](kelektiv@f046016))
sheerlox
added a commit
to sheerlox/node-cron
that referenced
this pull request
Sep 29, 2023
sheerlox
added
type:test
This was referenced Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Imported and adapted the types test file from
@types/cron.Note: The tests won't pass until #689 is merged since they detect the issue it fixes.
Related Issue
Motivation and Context
This adds more safety to our workflow regarding TypeScript types. Note that this only statically checks the types, so there is no assurance the runtime types would match.
Types of changes
Checklist:
!after the type/scope in the title (see the Conventional Commits standard).