Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(typescript): add missing "types" property to package.json #908

Merged

Conversation

sheerlox
Copy link
Collaborator

@sheerlox sheerlox commented Nov 4, 2024

Description

See related issue.

Related Issue

#906

Motivation and Context

How Has This Been Tested?

Untested, just followed the TypeScript doc: https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html#including-declarations-in-your-npm-package

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • If my change introduces a breaking change, I have added a ! after the type/scope in the title (see the Conventional Commits standard).

@sheerlox sheerlox added the type:build Changes that affect the build system or external dependencies label Nov 4, 2024
@sheerlox sheerlox requested a review from intcreator November 4, 2024 18:46
Copy link
Collaborator

@intcreator intcreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it

@intcreator intcreator merged commit 1953c97 into kelektiv:main Nov 4, 2024
15 checks passed
@ncb000gt
Copy link
Member

ncb000gt commented Nov 4, 2024

🎉 This PR is included in version 3.1.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

intcreator pushed a commit to Zamoca42/node-cron that referenced this pull request Nov 4, 2024
## [3.1.9](kelektiv/node-cron@v3.1.8...v3.1.9) (2024-11-04)

### 🛠 Builds

* **typescript:** add missing "types" property to package.json ([kelektiv#908](kelektiv#908)) ([1953c97](kelektiv@1953c97))

### 📚 Documentation

* Add .nvmrc with recommended Node version for development ([kelektiv#904](kelektiv#904)) ([91848e9](kelektiv@91848e9))

### ⚙️ Continuous Integrations

* **action:** update github/codeql-action action to v3.27.0 ([kelektiv#866](kelektiv#866)) ([a6dd871](kelektiv@a6dd871))
* **action:** update ossf/scorecard-action action to v2.4.0 ([kelektiv#883](kelektiv#883)) ([e0880a1](kelektiv@e0880a1))

### ♻️ Chores

* **config:** migrate renovate config ([kelektiv#903](kelektiv#903)) ([5ce34f4](kelektiv@5ce34f4))
* **deps:** lock file maintenance ([be77f4a](kelektiv@be77f4a))
* **deps:** update dependency [@fast-check](https://github.com/fast-check)/jest to v2 ([kelektiv#891](kelektiv#891)) ([20c448b](kelektiv@20c448b))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.17.2 ([24fa266](kelektiv@24fa266))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.17.3 ([5bd340e](kelektiv@5bd340e))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.17.4 ([1ce42a4](kelektiv@1ce42a4))
* **deps:** update dependency [@types](https://github.com/types)/node to v20.17.5 ([767c430](kelektiv@767c430))
* **deps:** update semantic-release related packages (major) ([kelektiv#835](kelektiv#835)) ([73a8d37](kelektiv@73a8d37))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released type:build Changes that affect the build system or external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants