Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throws warning: List doesn't get rendered when items are loaded async and select component is hidden #145

Merged
merged 2 commits into from
May 12, 2019
Merged

Throws warning: List doesn't get rendered when items are loaded async and select component is hidden #145

merged 2 commits into from
May 12, 2019

Conversation

yegor-babiy
Copy link
Contributor

Fixes #143

Proposed Changes

  • removed react-height package
  • replace approach with usage react-height
  • updated related snapshot

@yegor-babiy yegor-babiy requested a review from omerkenshoo May 1, 2019 11:21
@stepovat stepovat changed the title BREAKING CHANGE: List doesn't get rendered when items are loaded async and select component is hidden BREAKING CHANGES: List doesn't get rendered when items are loaded async and select component is hidden May 1, 2019
@stepovat
Copy link
Contributor

stepovat commented May 1, 2019

changed title to "breaking changes", with "s" in the end - otherwise release won't be triggered

@stepovat
Copy link
Contributor

stepovat commented May 1, 2019

Please check the inputs from "codeclimate/total-coverage"

@liorheber
Copy link
Collaborator

Why is this a breaking change? It has no effect on the API of the component as far as I see.

@liorheber liorheber mentioned this pull request May 2, 2019
Closed
@yegor-babiy yegor-babiy changed the title BREAKING CHANGES: List doesn't get rendered when items are loaded async and select component is hidden Throws warning: List doesn't get rendered when items are loaded async and select component is hidden May 2, 2019
@yegor-babiy
Copy link
Contributor Author

Why is this a breaking change? It has no effect on the API of the component as far as I see.

you are right, which changes I should made in PR?

@yegor-babiy
Copy link
Contributor Author

Please don't merge, got issue with React.createRef(), checking...

@stepovat
Copy link
Contributor

stepovat commented May 2, 2019 •
edited
Loading

@yegor-babiy regarding your question - changing the title is enough :)

@liorheber
Copy link
Collaborator

Not the title, need to ammend the commit message

@yegor-babiy
Copy link
Contributor Author

yegor-babiy commented May 2, 2019 •
edited
Loading

Issue was fixed

@yegor-babiy yegor-babiy force-pushed the fix-react-height-issue branch from d11f581 to 0eaec89 Compare May 2, 2019 10:33
@yegor-babiy
Copy link
Contributor Author

@liorheber, what do you think? can be merged?

@yegor-babiy yegor-babiy force-pushed the fix-react-height-issue branch from eb08a4b to c48e932 Compare May 8, 2019 08:33
@stepovat
Copy link
Contributor

stepovat commented May 8, 2019

@liorheber if no objections, I will merge in the evening

@stepovat stepovat merged commit 1148417 into master May 12, 2019
@stepovat stepovat deleted the fix-react-height-issue branch May 12, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepovat stepovat stepovat approved these changes

@omerkenshoo omerkenshoo Awaiting requested review from omerkenshoo

Assignees

@liorheber liorheber

@stepovat stepovat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List doesn't get rendered when items are loaded async and select component is hidden
3 participants
@yegor-babiy @stepovat @liorheber