Support importing npm modules by name #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leveraging node's `require.resolve` algorithm enables supporting all the ways in which a user expects to be able to require/import a module. Fixes kentcdodds#47
|
Thanks for this @jesstelford! I'm fine to merge if existing tests pass. Unfortunately this project is using some out-dated packages and needs to be updated before CI can get passing and an automated release can go out for this feature. The problem is that because I'm not actively using this package I can't dedicate any time to it. If you'd like to take a whack at updating all the packages as well as dropping support for unsupported versions of Node in our CI then I'd be willing to review and merge those PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Adds support for
codegen.require('module-name')to load and codegen the main export of an npm module. Fixes #47.Why:
I've created a reusable codegen which works great. However, once I published & consume the codegen as an npm module (
@ceteio/next-layout-loader), it no longer works. More details in #47.How:
Node's built-in
require.resolvealgorithm supports both relative paths, and module name specifiers. The second argument torequire.resolveallows specifying where to begin the search, which mirrors the existing behaviour, but adds the ability to load modules fromnode_modulesup the tree (should even work in monorepos!).Checklist:
Documentationn/a