fix(require): interop with destructuring transform / preset-env

[haltcase]

What:

require() destructuring becomes broken if using preset-env when it transforms the destructure. Would also be a factor if anyone used plugin-transform-destructuring on its own and put it before macros.

Why:

The transform-destructuring Babel plugin uses the VariableDeclaration visitor which comes before CallExpression. So by the time macros got to the require call it had already been transformed and was no longer a proper require(), leading to the previously fixed 'cannot read property referencePaths of undefined' error.

How:

To fix it we have to also use VariableDeclaration – plugin visitors are added before presets', so preset-env will also now work correctly.

@kentcdodds FYI I'm also planning to do a separate PR to fix handling of macros that use ESM to do export default createMacro(...) rather than module.exports = createMacro(...).

[codecov]

Codecov Report

Merging #51 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #51   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          73     74    +1     
  Branches       18     17    -1     
=====================================
+ Hits           73     74    +1

Impacted Files	Coverage Δ
src/index.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9438118...a9ddcc1. Read the comment docs.

[kentcdodds]

Wonderful!

[kentcdodds]

Thanks!

[kentcdodds]

Thanks so much for your help! I've added you as a collaborator on the project. Please make sure that you review the other/MAINTAINING.md and CONTRIBUTING.md files (specifically the bit about the commit messages and the git hooks) and familiarize yourself with the code of conduct (we're using the contributor covenant). You might also want to watch the repo to be notified when someone files an issue/PR. Please continue to make PRs as you feel the need (you can make your branches directly on the repo rather than your fork if you want). Thanks! And welcome to the team :)