This repository has been archived by the owner on Jan 6, 2021. It is now read-only.
fixes #150 exit code when os kills child process #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 64 65 +1
Branches 15 16 +1
=====================================
+ Hits 64 65 +1
Continue to review full report at Codecov.
|
kentcdodds
approved these changes
May 9, 2018
|
This has been published as |
This was referenced May 14, 2018
This was referenced Sep 6, 2024
This was referenced Sep 13, 2024
This was referenced Sep 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Solves #150
Why:
Ran into this issue when Circle-CI 2.0 runs out of memory, cross-env still reports the child process to exit with 0(success) when it was killed by the OS via SIGTERM.
How:
Keeping track of exit status of
childProcess.on('exit'), when exit code isnullthen the process was killed butnullshouldn't be passed to cross-env'sprocess.exitsince thenullargument is interpreted as zero.Checklist: