Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide options to transform module path #25

Merged
merged 5 commits into from
Sep 8, 2020

Conversation

chengjianhua
Copy link
Contributor

@chengjianhua chengjianhua commented Sep 6, 2020

before generating import statements

What:

Why:

To resolve the problem described in #24

How:

Provide an option in babel-plugin-macros.config.js to transform module path before generating import expressions.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

before generating import statements
@codecov
Copy link

codecov bot commented Sep 6, 2020

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           46        50    +4     
  Branches         4         5    +1     
=========================================
+ Hits            46        50    +4     
Impacted Files Coverage Δ
src/macro.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90ea0c1...81d7276. Read the comment docs.

src/macro.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! If you could just fix that one documentation thing then I think we should be good to go.

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid. Thanks!

@kentcdodds kentcdodds merged commit db59d16 into kentcdodds:master Sep 8, 2020
@kentcdodds
Copy link
Owner

@all-contributors please add @chengjianhua for code, tests, and docs

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @chengjianhua! 🎉

@kentcdodds
Copy link
Owner

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chengjianhua chengjianhua deleted the feat/transform-import branch September 9, 2020 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants