Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: hover over Supports cards #419

Closed
wants to merge 14 commits into from
Closed

add: hover over Supports cards #419

wants to merge 14 commits into from

Conversation

Aman172003
Copy link
Contributor

@Aman172003 Aman172003 commented Jul 17, 2024

This change resolves #2091 by adding hover effect to supports cards.

Type of change

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

How Has This Been Tested?

Changes were tested locally to ensure functionality.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added corresponding tests.
  • Any dependent changes have been merged and published in downstream modules.

@nehagup nehagup requested a review from Sonichigo July 18, 2024 09:43
@Aman172003
Copy link
Contributor Author

@Sonichigo could you please review the PR.

Aman172003 and others added 9 commits July 20, 2024 16:13
Signed-off-by: Aman Kumar Rai <tej171995@gmail.com>
Signed-off-by: starvader13 <ashutoshgupta1311@gmail.com>
Signed-off-by: Aman Kumar Rai <tej171995@gmail.com>
Signed-off-by: n-cekic <neckic13@gmail.com>
Co-authored-by: n-cekic <neckic13@gmail.com>
Co-authored-by: Neha Gupta <gneha21@yahoo.in>
Signed-off-by: Aman Kumar Rai <tej171995@gmail.com>
)

Added example for handling nested JSON fields

Closes #1892

Signed-off-by: GauriBhandari <bhandarigauri923@gmail.com>
Co-authored-by: Animesh Pathak <53110238+Sonichigo@users.noreply.github.com>
Signed-off-by: Aman Kumar Rai <tej171995@gmail.com>
Signed-off-by: starvader13 <ashutoshgupta1311@gmail.com>
Signed-off-by: Aman Kumar Rai <tej171995@gmail.com>
Signed-off-by: starvader13 <ashutoshgupta1311@gmail.com>
Signed-off-by: Aman Kumar Rai <tej171995@gmail.com>
* refactor: enterprise docs and seperate platform requirements (#409)

Signed-off-by: Neha Gupta <gneha21@yahoo.in>

* feat: update docs

Signed-off-by: Animesh Pathak <kurosakiichigo.songoku@gmail.com>

* feat: update rerecord cmd

Signed-off-by: Animesh Pathak <sonichigo@Animeshs-MacBook-Air-2.local>

* feat: update jenkins instruction

Signed-off-by: Animesh Pathak <kurosakiichigo.songoku@gmail.com>

---------

Signed-off-by: Neha Gupta <gneha21@yahoo.in>
Signed-off-by: Animesh Pathak <kurosakiichigo.songoku@gmail.com>
Co-authored-by: Neha Gupta <gneha21@yahoo.in>
Co-authored-by: Animesh Pathak <kurosakiichigo.songoku@gmail.com>
Signed-off-by: Aman Kumar Rai <tej171995@gmail.com>
Signed-off-by: Aman Kumar Rai <tej171995@gmail.com>
@Sonichigo
Copy link
Member

hey @Aman172003 ! How did the experienced change from current one on keploy.io/docs ?

Screen.Recording.2024-07-22.at.11.59.36.AM.mov

@Sonichigo
Copy link
Member

@Aman172003 are you working on this?

@Aman172003
Copy link
Contributor Author

@Aman172003 are you working on this?

yes

@Aman172003
Copy link
Contributor Author

@Sonichigo

Screen.Recording.2024-07-27.at.5.08.49.PM.mov

Initially both of the cards were not able to show any transition

Copy link
Member

@Sonichigo Sonichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add something for the darkmode as well. In Light Mode it looked good to me.

image

Added a hover effect to the input field for better user experience for both dark and light mode

Signed-off-by: Aman172003 <tej171995@gmail.com>
@Aman172003
Copy link
Contributor Author

@Sonichigo I have made the required changes.

Screen.Recording.2024-07-30.at.2.47.41.AM.mov

@Aman172003
Copy link
Contributor Author

@Sonichigo could you please guide...why getting the error

@Aman172003
Copy link
Contributor Author

@Sonichigo could you please close this pr, i want to raise a new pr with this issue

@Sonichigo Sonichigo closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: Supports cards on Keploy Documentation page should hover to make UI more intutive
6 participants