Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]: added example for handling nested JSON fields #421

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

GauriBhandari
Copy link
Contributor

@GauriBhandari GauriBhandari commented Jul 18, 2024

Pull Request Template

Description

This PR adds an example for handling deeply nested JSON fields in the Keploy configuration file. The added example illustrates how to specify paths for nested fields such as tokens in the global noise configuration.

Changes Made
Added an example JSON response demonstrating deeply nested fields.
Provided YAML configuration showing how to specify paths for nested fields in the global noise section.
Included detailed comments to help users understand the configuration.

Fixes keploy/keploy#1892

Type of change

Documentation Enhancement

  • This change requires a documentation update.

Additional Context (Please include any Screenshots/gifs if relevant)

...

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

@GauriBhandari
Copy link
Contributor Author

@Swpn0neel could you please help , what am i suppose to do now , i didn't get why i have again failed the DCO check , i have configure Docusaurus in my system as you instructed yesterday

@GauriBhandari
Copy link
Contributor Author

The issue has been solved @Swpn0neel , could you kindly review the pull request and merge it if everything looks good?

Copy link
Contributor

@Swpn0neel Swpn0neel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GauriBhandari
Copy link
Contributor Author

Thank you for reviewing the pull request @Swpn0neel . Since you mentioned that it looks good to you, could you please proceed with merging it?

@nehagup nehagup requested a review from khareyash05 July 18, 2024 09:45
Added example for handling nested JSON fields

Closes #1892

Signed-off-by: GauriBhandari <bhandarigauri923@gmail.com>
Copy link
Contributor

@khareyash05 khareyash05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GauriBhandari
Copy link
Contributor Author

Thank you for reviewing the pull request @Swpn0neel, @khareyash05 . Since you mentioned that it looks good to you, could you please proceed with merging it?

@khareyash05
Copy link
Contributor

Requesting @Sonichigo for approval

@khareyash05 khareyash05 requested a review from Sonichigo July 18, 2024 17:04
@Sonichigo Sonichigo merged commit 80a93ac into keploy:main Jul 19, 2024
5 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 19, 2024
)

Added example for handling nested JSON fields

Closes #1892

Signed-off-by: GauriBhandari <bhandarigauri923@gmail.com>
Co-authored-by: Animesh Pathak <53110238+Sonichigo@users.noreply.github.com>
starvader13 pushed a commit to starvader13/docs that referenced this pull request Jul 22, 2024
…eploy#421)

Added example for handling nested JSON fields

Closes #1892

Signed-off-by: GauriBhandari <bhandarigauri923@gmail.com>
Co-authored-by: Animesh Pathak <53110238+Sonichigo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs]: add nested fields example in config file
4 participants