Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FAQs to Keploy/docs website #428

Merged
merged 8 commits into from
Jul 26, 2024
Merged

Added FAQs to Keploy/docs website #428

merged 8 commits into from
Jul 26, 2024

Conversation

yaten2302
Copy link
Contributor

Pull Request Template

Description

This PR adds FAQ section to the docs website of Keploy.

Fixes keploy/keploy#2095

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added corresponding tests.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

@Sonichigo
Copy link
Member

@Sonichigo Sonichigo self-requested a review July 22, 2024 05:55
@yaten2302
Copy link
Contributor Author

@Sonichigo sir, could you please guide that why the build is failing and how can i fix this?

@Sonichigo
Copy link
Member

@Sonichigo sir, could you please guide that why the build is failing and how can i fix this?

Cause: Expected a closing tag for `<br>` (151:48-151:52) before the end of `paragraph`
Details:
{
  "column": 4,
  "message": "Expected a closing tag for `<br>` (151:48-151:52) before the end of `paragraph`",
  "line": 151,
  "name": "151:4-152:1[20](https://github.com/keploy/docs/actions/runs/10034678131/job/27731088374?pr=428#step:6:21)",
  "place": {
    "start": {
      "line": 151,
      "column": 4,
      "offset": 5[23](https://github.com/keploy/docs/actions/runs/10034678131/job/27731088374?pr=428#step:6:24)7,
      "_index": 0,
      "_bufferIndex": 0
    },

@yaten2302
Copy link
Contributor Author

@Sonichigo sir, I've made the changes, and also, I've rearranged the order of questions - keploy/keploy#2105 (review), now ig there are no build issues?

@Swpn0neel
Copy link
Contributor

Fix the DCO @yaten2302!

yaten2302 and others added 4 commits July 23, 2024 14:47
Signed-off-by: Yaten Dhingra <yaten598@gmail.com>
Signed-off-by: Yaten Dhingra <yaten598@gmail.com>
Signed-off-by: Animesh Pathak <kurosakiichigo.songoku@gmail.com>
Signed-off-by: Yaten Dhingra <yaten598@gmail.com>
@yaten2302
Copy link
Contributor Author

@Swpn0neel sir, fixed the DCO checks 👍

@Sonichigo
Copy link
Member

@Swpn0neel sir, fixed the DCO checks 👍

@yaten2302 the build is still failing

  "reason": "Expected a closing tag for `<br>` (151:47-151:51) before the end of `paragraph`",
  "ruleId": "end-tag-mismatch",
  "source": "mdast-util-mdx-jsx"

Please refer : - https://github.com/keploy/docs/actions/runs/10056225253/job/27806219617?pr=428

@yaten2302
Copy link
Contributor Author

@Sonichigo sir, actually, I use npm and not yarn, so is it creating problems because of that?

@Swpn0neel
Copy link
Contributor

Swpn0neel commented Jul 24, 2024

@Sonichigo sir, actually, I use npm and not yarn, so is it creating problems because of that?

actually, on line at line 151
tag is not close that's why build is failing.

@yaten2302
Copy link
Contributor Author

@Swpn0neel sir, actually, in all the questions, the tag is same - <br>, but then why this error is being shown only on line 151?

image

@Swpn0neel
Copy link
Contributor

image
Try that in all the lines!

Signed-off-by: Yaten Dhingra <yaten598@gmail.com>
@yaten2302
Copy link
Contributor Author

@Swpn0neel sir, I've made the changes, could you please review that now the build is working fine?

@Swpn0neel
Copy link
Contributor

@Sonichigo Kindly check!

Copy link
Member

@Sonichigo Sonichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sonichigo Sonichigo merged commit 11867b7 into keploy:main Jul 26, 2024
4 of 5 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
* added FAQs to Keploy/docs website

Signed-off-by: Yaten Dhingra <yaten598@gmail.com>

* fix: installation in docker with linux/wsl (#429)

Signed-off-by: Animesh Pathak <kurosakiichigo.songoku@gmail.com>

---------

Signed-off-by: Yaten Dhingra <yaten598@gmail.com>
Signed-off-by: Animesh Pathak <kurosakiichigo.songoku@gmail.com>
Co-authored-by: Animesh Pathak <kurosakiichigo.songoku@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs]: add FAQs for unit test gen
3 participants