From dd511c07a6f987e4f655c7ca56b840570f9e6e91 Mon Sep 17 00:00:00 2001 From: Kevin Locke Date: Tue, 17 Oct 2023 15:46:38 -0600 Subject: [PATCH] disable regexp/require-unicode-sets-regexp As with regexp/require-unicode-regexp, the pain outweighs the gain of enabling this rule at this point. Disable it. Signed-off-by: Kevin Locke --- rules/regexp.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/rules/regexp.js b/rules/regexp.js index fdc56ad..22956e2 100644 --- a/rules/regexp.js +++ b/rules/regexp.js @@ -63,6 +63,13 @@ module.exports = { // ASCII-only case-insensitive patterns) that it is counter-productive. "regexp/require-unicode-regexp": "off", + // Don't require v flag + // As with require-unicode-regexp, there are enough cases where v is not + // useful (e.g. literal patterns, ASCII-only case-insensitive patterns) + // that it is counter-productive. + // Additionally, it's only supported on Node.js 20 and later. + "regexp/require-unicode-sets-regexp": "off", + // Don't require elements of character classes to be sorted. // Although this is nice in theory, in practice I find sorting ASCII // punctuation before numbers and letters to be more difficult to read.