Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React 18? #208

Closed
garcikg0 opened this issue Apr 15, 2022 · 4 comments
Closed

Upgrade to React 18? #208

garcikg0 opened this issue Apr 15, 2022 · 4 comments

Comments

@garcikg0
Copy link

garcikg0 commented Apr 15, 2022

🐛 Bug report

Summary of issue

Unable to resolve dependency tree when trying to install using "npm i react-circular-progressbar" command in terminal.

Reproducible example

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: pomodor-timer-frontend@0.1.0
npm ERR! Found: react@18.0.0
npm ERR! node_modules/react
npm ERR! react@"^18.0.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^0.14.0 || ^15.0.0 || ^16.0.0 || ^17.0.0" from react-circular-progressbar@2.0.4
npm ERR! node_modules/react-circular-progressbar
npm ERR! react-circular-progressbar@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Your environment

  • What browser version were you using? Firefox
  • What version of react-circular-progressbar are you using? Latest I believe
@altanaldeniz
Copy link
Contributor

altanaldeniz commented Apr 27, 2022

You can try the command: npm install react-circular-progressbar --force until the library gets fixed.

@rhazegh
Copy link

rhazegh commented May 23, 2022

Since React 18 is backwards compatible with 17, do we only need to edit package.json and make the following changes?

"version": "2.0.5",
  "peerDependencies": {
    "react": "^0.14.0 || ^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0"
  }

@ngothiensinh
Copy link

There's a PR active. Try the command: npm i --save kevinsqi/react-circular-progressbar#pull/209/head until it gets merged

@kevinsqi
Copy link
Owner

Sorry for the delay here; this should be fixed in 2.1.0 with #209. Let me know if there are other issues here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants