Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use interface types for TrackerHit #252

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

tmadlener
Copy link
Contributor

@tmadlener tmadlener commented Jan 19, 2024

BEGINRELEASENOTES

  • Make the edm4hep::TrackerHit an interface type and use that in the edm4hep::Track.
  • Rename the current edm4hep::TrackerHit to edm4hep::TrackerHit3D
  • This is a breaking change. However, we currently do not plan to implement schema evolution for this

ENDRELEASENOTES

This is one of a few rather breaking changes that we plan to do in the near future towards an EDM4hep version 1.0.

Fixes #218

edm4hep.yaml Outdated Show resolved Hide resolved
edm4hep.yaml Outdated Show resolved Hide resolved
@tmadlener tmadlener force-pushed the trackerhit-interface branch 2 times, most recently from 2c46765 to 7dd0e8c Compare February 22, 2024 14:52
@jmcarcell
Copy link
Member

I'm not sure how to fix the CI for this one. So it fails because it picks up the FCCAnalyses dictionaries and headers and there something wants TrackerHitData.h which doesn't exist anymore with this PR. Why ROOT does this when it's not needed I don't know. Locally the tests pass for me without FCCAnalyses so one option would be to remove FCCAnalyses in the environment for the tests as they should be only related to EDM4hep. However this is useful information since people using EDM4hep in Key4hep will have FCCAnalyses in the environment, so we can be aware if something is failing. I think I'll just modify the environment and add a test to the tests that run post-build so that we would be aware if there were issues like this one.

@tmadlener
Copy link
Contributor Author

The problem here is that LD_LIBRARY_PATH is still in the test environment. FCCAnalyses from the nightlies is still built against the older EDM4hep, so it still has a TrackerHitData. ROOT picks up things pretty indiscriminantely from there. This would be solvable in EDM4hep probably by constructing the test environment to contain exactly what it needs, because there is no FCCAnalyses in the LCG stacks. LCG stack environments are pretty impossible to deal with in these cases because there is almost always something that pulls in <lcg-view-path>/lib[64].

@tmadlener tmadlener force-pushed the trackerhit-interface branch from 0b2c900 to a436b15 Compare February 23, 2024 08:32
@tmadlener tmadlener merged commit 96d4ab8 into key4hep:main Feb 23, 2024
9 of 13 checks passed
@tmadlener tmadlener deleted the trackerhit-interface branch February 23, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling of different TrackerHit types
2 participants