Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Resend OTP endpoint #326

Closed
rajdip-b opened this issue Jul 6, 2024 · 8 comments · Fixed by #445
Closed

API: Resend OTP endpoint #326

rajdip-b opened this issue Jul 6, 2024 · 8 comments · Fixed by #445
Assignees
@Prakhargarg-2010196
Labels
difficulty: 2 foss hack Clustering all the curated issues for Foss Hack 2024 good first issue Good for newcomers priority: high released scope: api Everything related to the API type: feature Release drafter tag for tagging PRs related to adding new features

Comments

@rajdip-b
Copy link
Member

rajdip-b commented Jul 6, 2024

Description

Add an implementation to support resending OTP to the user.

Solution

  • Add an endpoint resend-otp/:email in auth.controller.ts
  • Add a service level implementation of the same in auth.service.ts
  • Ideally, we want to rate limit this to ensure users don't get to call this endpoint in a short interval. We would like to impose a timeout of 1 minute per email address to invoke this endpoint. Refer to this
  • Note that, we just want to check if the user by the exists in the database. If yes, we want to resend the OTP.
@rajdip-b rajdip-b added good first issue Good for newcomers scope: api Everything related to the API type: feature Release drafter tag for tagging PRs related to adding new features priority: high foss hack Clustering all the curated issues for Foss Hack 2024 difficulty: 2 labels Jul 6, 2024
@rajdip-b rajdip-b moved this to Todo in keyshade-api Jul 6, 2024
This was referenced Jul 6, 2024
Closed
Closed
@RockingThor
Copy link

Will love to work on this issue. Can I get this assigned to me, please?

@rajdip-b
Copy link
Member Author

rajdip-b commented Jul 9, 2024

Sure @RockingThor!

Please read through our documentation and our contribution guidelines and feel free to get started :D

@rajdip-b rajdip-b moved this from Todo to In progress in keyshade-api Jul 9, 2024
@rajdip-b rajdip-b moved this from In progress to Todo in keyshade-api Sep 4, 2024
@Prakhargarg-2010196
Copy link
Contributor

Did the api for this got implemented or is it yet to be done ? @rajdip-b

@rajdip-b
Copy link
Member Author

I don't think so. It's still up for grabs.

@Prakhargarg-2010196
Copy link
Contributor

Prakhargarg-2010196 commented Sep 12, 2024 •
edited
Loading

Okay One more thing can you guide me a little how to setup that smtp thing mentioned in the docs?

@Prakhargarg-2010196
Copy link
Contributor

/attempt

@github-actions GitHub Actions
Copy link

Assigned the issue to @Prakhargarg-2010196!

@Prakhargarg-2010196 Prakhargarg-2010196 mentioned this issue Sep 17, 2024
Merged
6 tasks
@rajdip-b rajdip-b moved this from Todo to In progress in keyshade-api Oct 4, 2024
@Prakhargarg-2010196 Prakhargarg-2010196 mentioned this issue Oct 8, 2024
Closed
@github-project-automation github-project-automation bot moved this from In progress to Done in keyshade-api Oct 13, 2024
@rajdip-b rajdip-b moved this from Done to Queued for release in keyshade-api Oct 13, 2024
@rajdip-b
Copy link
Member Author

🎉 This issue has been resolved in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Prakhargarg-2010196 Prakhargarg-2010196

Labels
difficulty: 2 foss hack Clustering all the curated issues for Foss Hack 2024 good first issue Good for newcomers priority: high released scope: api Everything related to the API type: feature Release drafter tag for tagging PRs related to adding new features
Projects
keyshade-api
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(api): Add resend otp implementation Prakhargarg-2010196/keyshade
3 participants
@Prakhargarg-2010196 @rajdip-b @RockingThor