Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Add prod environment #357

Closed
rajdip-b opened this issue Jul 11, 2024 · 9 comments · Fixed by #436
Closed

API: Add prod environment #357

rajdip-b opened this issue Jul 11, 2024 · 9 comments · Fixed by #436
Assignees
@unamdev0
Labels
difficulty: 2 foss hack Clustering all the curated issues for Foss Hack 2024 good first issue Good for newcomers help wanted Extra attention is needed priority: urgent released scope: api Everything related to the API type: chore Release drafter tag for tagging PRs related to making patches to general code

Comments

@rajdip-b
Copy link
Member

Description

Add a prod environment support in API's zod schema parser. We want to move out the Sentry stuff from devEnvironment to prodEnvironment

keyshade/apps/api/src/common/env/env.schema.ts

Lines 50 to 55 in 1756727

SENTRY_DSN: z.string().optional(),
SENTRY_ORG: z.string().optional(),
SENTRY_PROJECT: z.string().optional(),
SENTRY_TRACES_SAMPLE_RATE: z.string().optional(),
SENTRY_PROFILES_SAMPLE_RATE: z.string().optional(),
SENTRY_ENV: z.string().optional(),

@rajdip-b rajdip-b added good first issue Good for newcomers help wanted Extra attention is needed scope: api Everything related to the API type: chore Release drafter tag for tagging PRs related to making patches to general code priority: urgent difficulty: 2 labels Jul 11, 2024
@rajdip-b rajdip-b moved this to Todo in keyshade-api Jul 11, 2024
@jamesfrye420
Copy link
Contributor

how exactly would the validation change?

@rajdip-b
Copy link
Member Author

rajdip-b commented Jul 13, 2024 •
edited
Loading

We want to remove the sentry stuff from dev environment into prod environment, and also add a NODE_ENV=prod type. Everything that we have in dev env should also be in prod btw.

@jamesfrye420
Copy link
Contributor

Cool I'll look into it within this week

@rajdip-b rajdip-b added the foss hack Clustering all the curated issues for Foss Hack 2024 label Jul 20, 2024
@manasveer6
Copy link

/attempt

@github-actions GitHub Actions
Copy link

Assigned the issue to @manasveer6!

@rajdip-b
Copy link
Member Author

rajdip-b commented Sep 4, 2024

@manasveer6 any progress?

@unamdev0
Copy link
Contributor

/attempt

@github-actions GitHub Actions
Copy link

Assigned the issue to @unamdev0!

@rajdip-b rajdip-b moved this from Todo to In progress in keyshade-api Sep 16, 2024
@unamdev0 unamdev0 mentioned this issue Sep 16, 2024
Merged
@github-project-automation github-project-automation bot moved this from In progress to Done in keyshade-api Sep 16, 2024
@rajdip-b rajdip-b moved this from Done to Queued for release in keyshade-api Sep 16, 2024
@rajdip-b
Copy link
Member Author

🎉 This issue has been resolved in version 2.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unamdev0 unamdev0

Labels
difficulty: 2 foss hack Clustering all the curated issues for Foss Hack 2024 good first issue Good for newcomers help wanted Extra attention is needed priority: urgent released scope: api Everything related to the API type: chore Release drafter tag for tagging PRs related to making patches to general code
Projects
keyshade-api
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(api): Add prod env schema in env file unamdev0/keyshade
4 participants
@unamdev0 @jamesfrye420 @rajdip-b @manasveer6