-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api-client): Create controller for Secret module #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed to generate code suggestions for PR |
@rajdip-b Can u give it a look whenever you are free. |
rajdip-b
requested changes
Jul 28, 2024
rajdip-b
requested changes
Jul 28, 2024
rajdip-b
force-pushed
the
api-client/secret
branch
from
August 2, 2024 12:25
603736b
to
28fdd3a
Compare
@vr-varad can you start with this pr? please make the changes as we have done in environments controller. |
@rajdip-b Yeah Sure |
vr-varad
force-pushed
the
api-client/secret
branch
from
August 2, 2024 18:26
6574b4a
to
d0555d4
Compare
@rajdip-b Can u review it whenever u are free |
rajdip-b
approved these changes
Aug 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rajdip-b
pushed a commit
that referenced
this pull request
Sep 5, 2024
Co-authored-by: vr-varad <varadgupta21#gmail.com>
rajdip-b
pushed a commit
that referenced
this pull request
Sep 5, 2024
## [2.4.0](v2.3.0...v2.4.0) (2024-09-05) ### 🚀 Features * **api-client:** Create controller for Event module ([#399](#399)) ([122df35](122df35)) * **api-client:** Create controller for Integration module ([#397](#397)) ([697d38b](697d38b)) * **api-client:** Create controller for Project module ([#370](#370)) ([fa25866](fa25866)) * **api-client:** Create controller for Secret module ([#396](#396)) ([7e929c0](7e929c0)) * **api-client:** Create controller for Variable module ([#395](#395)) ([3e114d9](3e114d9)) * **api:** Add global search in workspace ([c49962b](c49962b)) * **api:** Add max page size ([#377](#377)) ([ed18eb0](ed18eb0)) * **cli:** Add functionality to operate on Environments ([#324](#324)) ([4c6f3f8](4c6f3f8)) * **cli:** Quit on decryption failure ([#381](#381)) ([1349d15](1349d15)) ### 🐛 Bug Fixes * **api-client:** Fixed broken export ([096df2c](096df2c)) * **api:** Add NotFound exception on passing an invalid roleId while inviting user in workspace ([#408](#408)) ([ab441db](ab441db)) * **cli:** Fixed missing module ([f7a091f](f7a091f)) * **platform:** Build failure in platform ([#385](#385)) ([90dcb2c](90dcb2c)) ### 🔧 Miscellaneous Chores * Add api client build script and updated CI ([da0e27a](da0e27a)) * **api:** Reorganized import using path alias ([d5befd1](d5befd1)) * **ci:** Update CLI CI name ([8f4c456](8f4c456)) * **cli:** Add Zod validation to parseInput function ([#362](#362)) ([34e6c39](34e6c39)) * Fixed api client tests and rearranged controllers ([1307604](1307604)) * Housekeeping ([c5f1330](c5f1330)) * **platform:** Added strict null check ([072254f](072254f)) * **web:** Added strict null check ([7e12b47](7e12b47)) ### 🔨 Code Refactoring * **api:** Update logic for forking projects ([#398](#398)) ([4cf3838](4cf3838))
Kiranchaudhary537
pushed a commit
to Kiranchaudhary537/keyshade
that referenced
this pull request
Oct 13, 2024
## [2.4.0](keyshade-xyz/keyshade@v2.3.0...v2.4.0) (2024-09-05) ### 🚀 Features * **api-client:** Create controller for Event module ([keyshade-xyz#399](keyshade-xyz#399)) ([122df35](keyshade-xyz@122df35)) * **api-client:** Create controller for Integration module ([keyshade-xyz#397](keyshade-xyz#397)) ([697d38b](keyshade-xyz@697d38b)) * **api-client:** Create controller for Project module ([keyshade-xyz#370](keyshade-xyz#370)) ([fa25866](keyshade-xyz@fa25866)) * **api-client:** Create controller for Secret module ([keyshade-xyz#396](keyshade-xyz#396)) ([7e929c0](keyshade-xyz@7e929c0)) * **api-client:** Create controller for Variable module ([keyshade-xyz#395](keyshade-xyz#395)) ([3e114d9](keyshade-xyz@3e114d9)) * **api:** Add global search in workspace ([c49962b](keyshade-xyz@c49962b)) * **api:** Add max page size ([keyshade-xyz#377](keyshade-xyz#377)) ([ed18eb0](keyshade-xyz@ed18eb0)) * **cli:** Add functionality to operate on Environments ([keyshade-xyz#324](keyshade-xyz#324)) ([4c6f3f8](keyshade-xyz@4c6f3f8)) * **cli:** Quit on decryption failure ([keyshade-xyz#381](keyshade-xyz#381)) ([1349d15](keyshade-xyz@1349d15)) ### 🐛 Bug Fixes * **api-client:** Fixed broken export ([096df2c](keyshade-xyz@096df2c)) * **api:** Add NotFound exception on passing an invalid roleId while inviting user in workspace ([keyshade-xyz#408](keyshade-xyz#408)) ([ab441db](keyshade-xyz@ab441db)) * **cli:** Fixed missing module ([f7a091f](keyshade-xyz@f7a091f)) * **platform:** Build failure in platform ([keyshade-xyz#385](keyshade-xyz#385)) ([90dcb2c](keyshade-xyz@90dcb2c)) ### 🔧 Miscellaneous Chores * Add api client build script and updated CI ([da0e27a](keyshade-xyz@da0e27a)) * **api:** Reorganized import using path alias ([d5befd1](keyshade-xyz@d5befd1)) * **ci:** Update CLI CI name ([8f4c456](keyshade-xyz@8f4c456)) * **cli:** Add Zod validation to parseInput function ([keyshade-xyz#362](keyshade-xyz#362)) ([34e6c39](keyshade-xyz@34e6c39)) * Fixed api client tests and rearranged controllers ([1307604](keyshade-xyz@1307604)) * Housekeeping ([c5f1330](keyshade-xyz@c5f1330)) * **platform:** Added strict null check ([072254f](keyshade-xyz@072254f)) * **web:** Added strict null check ([7e12b47](keyshade-xyz@7e12b47)) ### 🔨 Code Refactoring * **api:** Update logic for forking projects ([keyshade-xyz#398](keyshade-xyz#398)) ([4cf3838](keyshade-xyz@4cf3838))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Api client Controller for Secret Module
Fixes #352
Dependencies
Mention any dependencies/packages used
Future Improvements
Mention any improvements to be done in future related to any file/feature
Mentions
Mention and tag the people
Screenshots of relevant screens
Add screenshots of relevant screens
Developer's checklist
If changes are made in the code:
Documentation Update