From 1ed2dea8cf9971200bb83e1dd3322a27be06c363 Mon Sep 17 00:00:00 2001 From: Jed Watson Date: Tue, 13 Jul 2021 10:17:41 +1000 Subject: [PATCH] Cleanup todos (#6086) * Remove old TODOs * Remove unused frontmatter from STYLE_GUIDE --- STYLE_GUIDE.md | 5 --- packages-next/TODO.md | 34 -------------------- packages-next/fields/TODO.md | 62 ------------------------------------ 3 files changed, 101 deletions(-) delete mode 100644 packages-next/TODO.md delete mode 100644 packages-next/fields/TODO.md diff --git a/STYLE_GUIDE.md b/STYLE_GUIDE.md index 86446d68d2a..cf902247937 100644 --- a/STYLE_GUIDE.md +++ b/STYLE_GUIDE.md @@ -1,8 +1,3 @@ - - # Documentation Style This document describes the conventions for formatting and style used throughout Keystone 6 docs. diff --git a/packages-next/TODO.md b/packages-next/TODO.md deleted file mode 100644 index a12693daf76..00000000000 --- a/packages-next/TODO.md +++ /dev/null @@ -1,34 +0,0 @@ -# Major work left to release the next packages - -- [x] Make it work for JS -- [ ] Test package installs with local registry (use pnpm first to find missing deps) -- [ ] Make sure we have the right peerDeps -- [x] Rename `admin` to `ui` in config -- [ ] Publish the packages to a preview scope (`@keystone-next`) -- [ ] Clean up stable set of features - - [ ] Custom views @mitchell - - [x] Unbreak the date field @mitchell - - [x] Unbreak showing errors for incorrect password on signin @mitchell - - [ ] Create mode for Passwords @jed - - [x] Validate create initial item form @mitchell - - [ ] No items display on the List screen @jed - - [x] Always hide virtual fields in the create form - - [x] Special case validation errors and display them nicely @mitchell -- [ ] Figure out how it works in prod - - [ ] Server (e.g Heroku) -- [ ] Review example projects / clean up, etc -- [ ] Plan documentation / website - ---- - -## Next steps after alpha release - -- [ ] Improve generated types -- [ ] Review APIs for data interaction (crud, executeQuery, etc) -- [ ] Review how we're returning errors from the GraphQL API -- [ ] Review how the search field (and query input) works -- [ ] Revisit design system and theming -- [ ] Plan updated set of field types -- [ ] Figure out how it works in prod - - [ ] Serverless (e.g Vercel / Lambda) - - [ ] Deploying GraphQL API and Admin UI independently diff --git a/packages-next/fields/TODO.md b/packages-next/fields/TODO.md deleted file mode 100644 index 7e32f04b746..00000000000 --- a/packages-next/fields/TODO.md +++ /dev/null @@ -1,62 +0,0 @@ -# General - -- [ ] Review types for defaultValue across all fields -- [ ] Review types for hooks, specifically including GraphQLInput - -# Field Types - -## Password - -- [x] Add Password Field - -## Select - -- [x] Add Select Field -- [x] Current UI with a Select -- [x] New UI Mode with a SegmentedControl - -## Relationship - -- [x] Make a functional Relationship Field UI as per the current Relationship field (i.e just a select) - -# Date / Time Types Reboot - -- [ ] Talk about aligning the naming of these with temporal - -## Timestamp - -The current `DateTimeUtc` type; a point in time; effectively a datetime at UTC and/or epoch - -- [ ] Add a Timestamp Field -- [ ] Add DatePicker and TimePicker components to the Design System - -## Timezone - -Basically a preconfigured select. See - -- [ ] Add Timezone Field -- [ ] Allow formatting date input in the field resolver (see ) - -## LocalDateTime - -Combines both Timestamp and Timezone into a single field. See - -- [ ] Add a LocalDateTime field type -- [ ] Allow formatting the date in the field resolver (see ) - -## CalendarDay - -As per the current implementation - -- [ ] Add a CalendarDay field type - -## Time - -New field type for storing a time of day. - -> It would be nice to capture the intent of "this time of day, every day, regardless of time zone or offset" in a type. -> I imagine we'd store it as per the time part of an ISO 8601 string (ie. HH:mm:ss.nnn) with millisecond precision. -> – - -- [ ] Write up the spec in an issue -- [ ] Add a Time field type