Android Gradle Plugin 3.5.0 Compatibility

[llDavidll]

Hi,

The latest Android Gradle plugin breaks the fat-aar plugin :

Cannot expand ZIP '****\intermediates\compile_only_not_namespaced_r_class_jar\release\generateReleaseRFile\R.jar' as it does not exist.

Path of the R.jar file with 3.4.2 :
intermediates\compile_only_not_namespaced_r_class_jar\release\generateReleaseRFile\R.jar
Path of the R.jar file with 3.5.0 :
intermediates\compile_only_not_namespaced_r_class_jar\release\R.jar

One step is really important : clean before trying to reproduce this error. Without a clean, old generated files are still present and are used by the plugin.

I think the fix should be made here by adding another case without the last part of the path (/generate${mVariant.name.capitalize()}RFile) :

fat-aar-android/source/src/main/groovy/com/kezong/fataar/VersionAdapter.groovy

Line 36 in 22e2a04

ConfigurableFileCollection getRClassPath() {

I tried to build by manually puting the R.jar file in the old path and it seems to work, so it may be the only broken thing.

[llDavidll]

I have another issue linked to the new Android Gradle Plugin :

• Embed a dependency :
  embed 'your:dependency'
  Then build the project : the dependency is present in the aar.

• Remove the dependency completely or replace "embed" by "api":
  api 'your:dependency'
  Build the project again. The dependency should not be in the aar, but it is.

• Clean the project, rebuild : this time the dependency will not be in the aar.

This bug is only present in the 3.5.0.

[kezong]

Thanks for your issue, I will take time to look at this.

[krmao]

I am also find this bug about classpath 'com.android.tools.build:gradle:3.5.0'

[victorlaerte]

Also got this issue. Downgrade for 3.4.2 works until this is fixed.

[kezong]

I adapted 3.5.0 in fat-aar 1.2.6。
You can upgrade it.

[llDavidll]

Great, both issues have been fixed. Thank you for your time !

[awushensky]

This issue has resurfaced with gradle 4.1.0. Seems to work ok on 4.0.2

[duanniston]

This issue has resurfaced with gradle 4.1.0. Seems to work ok on 4.0.2

Yes