Improve action UX and state storage #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows tracking moves seperately from deltas, since sometimes multiple deltas belong to a single move. This also allows IDs for all items that are stored in state to be generated and persisted without interfering with moves. This was necessary to ensure that modifiers always show up in the same place in the toolbar since they are sorted by their persisted IDs.
Modifiers will always show up in the order defined in configuration now and will retain their place even if ownership changes.
kflorence
changed the title
kflorence
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leave actions centered and ensure that they will wrap as needed on smaller devices. Also ensure that they are listed in the toolbar in the order they are defined in configuration (global first, then tile level), and that the order sticks even when ownership changes.
As part of this change, the concept of 'moves' has been added to the cached state which allows explicitly defining when a user has made a move, instead of just counting each state update as a move (or throwing it out entirely). This also allows the puzzle to assign IDs to everything the first time it starts up and re-use those IDs from cache. That ensures IDs will not change between page loads, which can make it easier to debug and also allows for logic related to IDs (such as sorting) to be persistent.